Fix irmago v0.19.1 API compatibility for StartSession method#4025
Fix irmago v0.19.1 API compatibility for StartSession method#4025Copilot wants to merge 3 commits intodependabot/go_modules/github.com/privacybydesign/irmago-0.19.1from
Conversation
Updated the signingSessionHandler interface and mock implementations to match the new irmago v0.19.1 StartSession method signature which now requires a requestor string parameter. Co-authored-by: reinkrul <1481228+reinkrul@users.noreply.github.com>
Added comments explaining the purpose of the requestor parameter and why an empty string is used in the nuts-node context. Co-authored-by: reinkrul <1481228+reinkrul@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
Coverage Impact Unable to calculate total coverage change because base branch coverage was not found. Modified Files with Diff Coverage (1)
🤖 Increase coverage with AI coding...🚦 See full report on Qlty Cloud » 🛟 Help
|

The irmago v0.19.1 upgrade introduced a breaking change:
StartSessionnow requires arequestor stringparameter to identify the session initiator.Changes
signingSessionHandlerinterface: Addedrequestor stringparameter toStartSessionmethod signatureStartSessioninvocation: Pass empty string as requestor (appropriate for single-requestor architecture)mockIrmaClient.StartSessionto match new signatureThe requestor parameter is passed as an empty string since nuts-node operates as a single IRMA session requestor.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.