fix: don't clone request in prefix stripping#70
Open
mromaszewicz wants to merge 1 commit intooapi-codegen:mainfrom
Open
fix: don't clone request in prefix stripping#70mromaszewicz wants to merge 1 commit intooapi-codegen:mainfrom
mromaszewicz wants to merge 1 commit intooapi-codegen:mainfrom
Conversation
Closes: oapi-codegen#69 Replace makeRequestForValidation (which used r.Clone()) with withPrefixStripped, which temporarily modifies the request's path fields in place and restores them after validation. r.Clone() shallow-copies the Body, so when validation consumed the body on the clone, the original request passed to the handler had an empty body, causing 'EOF' errors on decode. The new approach mutates the path fields for the duration of route finding and validation, then restores them before the handler or error handler sees the request. No clone, no body sharing, no buffering of potentially large request bodies. The r.Clone() was only done as a way to back up the request URI to send the prefix-stripped request into validation. Fixes oapi-codegen#69 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
LGTM, I confirm that fix the issue #69 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #69
Replace makeRequestForValidation (which used r.Clone()) with withPrefixStripped, which temporarily modifies the request's path fields in place and restores them after validation.
r.Clone() shallow-copies the Body, so when validation consumed the body on the clone, the original request passed to the handler had an empty body, causing 'EOF' errors on decode.
The new approach mutates the path fields for the duration of route finding and validation, then restores them before the handler or error handler sees the request. No clone, no body sharing, no buffering of potentially large request bodies.
The r.Clone() was only done as a way to back up the request URI to send the prefix-stripped request into validation.
Fixes #69