Skip to content

Modify entrypoint.sh to handle exit codes #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
effoeffi merged 3 commits into from
Sep 23, 2025
Merged

Modify entrypoint.sh to handle exit codes #63

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d94b56
Modify entrypoint.sh to handle exit codes
madkoo Sep 19, 2025
aed843d
Refactor output writing in entrypoint.sh
madkoo Sep 21, 2025
4471e3a
Fix exit code handling in entrypoint.sh
madkoo Sep 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions diff/entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,16 +62,22 @@ echo "diff<<$delimiter" >>"$GITHUB_OUTPUT"

set -o pipefail

# Capture the exit code from oasdiff command while still getting the output
exit_code=0
if [ -n "$flags" ]; then
output=$(oasdiff diff "$base" "$revision" $flags)
output=$(oasdiff diff "$base" "$revision" $flags) || exit_code=$?
else
output=$(oasdiff diff "$base" "$revision")
output=$(oasdiff diff "$base" "$revision") || exit_code=$?
fi

if [ -n "$output" ]; then
write_output "$output"
write_output "$output"
Copy link
Contributor

@effoeffi effoeffi Sep 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the space at the end of the line

else
write_output "No changes"
fi

echo "$delimiter" >>"$GITHUB_OUTPUT"
# Always close the multiline output format properly
echo "$delimiter" >>"$GITHUB_OUTPUT"

# Exit with the original exit code from oasdiff
exit $exit_code
Loading