(fix)logger use-after-free in ZeLogger during teardown#483
Merged
Conversation
Replace the thread_local std::string line/tid buffers with POD thread_local char buffers, so log calls that arrive during exit teardown no longer write into freed memory. ALso add stand alone ASan regression test. Signed-off-by: Russell McGuire <russell.w.mcguire@intel.com>
nrspruit
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the thread_local std::string line/tid buffers with POD thread_local char buffers, so log calls that arrive during exit teardown no longer write into freed memory.
Also add stand alone ASan regression test.