fix: ISSUE-1919 Domain client event handlers no longer disappear

[man85]

This PR

• fixes disappearing of Domain client event handlers

Related Issues

Fixes #1919

Notes

Follow-up Tasks

How to test

[gemini-code-assist]

Code Review

This pull request updates EventSupport.java to return a new HashSet of domain names and adds a test case to OpenFeatureAPITest.java to ensure that configuration change events are correctly handled for both domainless and domain-specific providers. A review comment correctly identified that a TODO suggestion in the code regarding Set.copyOf was misleading, as the caller requires a mutable set to perform removeAll operations without triggering an UnsupportedOperationException.

[gemini-code-assist]

The suggestion to use Set.copyOf is incorrect in this context. Set.copyOf (introduced in Java 10) returns an unmodifiable set. However, the caller of this method in OpenFeatureAPI.runHandlersForProvider (line 466) calls removeAll on the returned set. Using an unmodifiable set would result in an UnsupportedOperationException at runtime. It is safer to remove this misleading comment.

Suggested change

	// TODO Java 8 in documentation https://openfeature.dev/docs/tutorials/getting-started/java/spring-boot/#requirements, but Java 11 in https://github.com/open-feature/java-sdk/pull/1393
	// 'Set.copyOf' can be used instead of 'new HashSet<>' in case of Java 11
	return new HashSet<>(this.handlerStores.keySet());
	return new HashSet<>(this.handlerStores.keySet());

[man85]

The suggestion to use Set.copyOf was removed

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud