-
Notifications
You must be signed in to change notification settings - Fork 23
feat: update opentelemetry hook to latest version of semantic conventions #326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @federicobond, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request upgrades the OpenTelemetry hook to adhere to the most recent OpenTelemetry semantic conventions for feature flags. The primary goal is to enrich the tracing data generated during feature flag evaluations by incorporating more detailed attributes, thereby improving observability and troubleshooting capabilities. This involves adding a new dependency and refactoring the event attribute structure. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
0fc0119 to
3e2da02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the OpenTelemetry hook to align with the latest semantic conventions, which is a valuable improvement. The changes are well-implemented, and the tests have been updated accordingly to cover the new logic. I have a couple of suggestions to enhance dependency management and improve code clarity.
hooks/openfeature-hooks-opentelemetry/src/openfeature/contrib/hook/opentelemetry/__init__.py
Outdated
Show resolved
Hide resolved
49431a2 to
641b65d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #326 +/- ##
==========================================
+ Coverage 94.56% 95.04% +0.47%
==========================================
Files 22 22
Lines 1068 1090 +22
==========================================
+ Hits 1010 1036 +26
+ Misses 58 54 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Test failures are related to open-feature/python-sdk#552. We can work around that or require a version with that fix. |
7ba82b6 to
72ab648
Compare
|
@gruebel there are some build failures related to protobuf in the
Edit: fix is now in |
258b4ee to
01fae9c
Compare
…ions Signed-off-by: Federico Bond <[email protected]>
01fae9c to
6b5fe18
Compare
This PR
Updates the OTel hook to support the latest version of semantic conventions published at:
https://opentelemetry.io/docs/specs/semconv/registry/attributes/feature-flag/