fix:add missing assignee/q params and fix status/accessType array types in List DAR#28895
Merged
Conversation
Contributor
✅ PR checks passedThe linked issue has a description and all required Shipping project fields set. Thanks! |
aniketkatkar97
approved these changes
Jun 10, 2026
ShaileshParmar11
approved these changes
Jun 10, 2026
Contributor
|
Contributor
🟡 Playwright Results — all passed (13 flaky)✅ 4271 passed · ❌ 0 failed · 🟡 13 flaky · ⏭️ 88 skipped
🟡 13 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
Code Review ✅ ApprovedAdds missing assignee and query parameters to the DAR list filter and updates status and accessType fields to support array types. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes #28893
assignee?: string— used by the DAR widget, marketplace widget, and list page to filter "My Approvals" tasks by the current user's FQN and team FQNs.q?: string— used by the list page free-text search filter.status?: TaskStatus→status?: TaskStatus | TaskStatus[]to match how the list page passes a multi-select array from the status filter dropdown.accessType?: DataAccessType→accessType?: DataAccessType | DataAccessType[]for the same reason.