Skip to content

fix:add missing assignee/q params and fix status/accessType array types in List DAR#28895

Merged
anuj-kumary merged 2 commits into
mainfrom
issue-#28893
Jun 10, 2026
Merged

fix:add missing assignee/q params and fix status/accessType array types in List DAR#28895
anuj-kumary merged 2 commits into
mainfrom
issue-#28893

Conversation

@anuj-kumary

@anuj-kumary anuj-kumary commented Jun 10, 2026

Copy link
Copy Markdown
Member

Fixes #28893

  • Add assignee?: string — used by the DAR widget, marketplace widget, and list page to filter "My Approvals" tasks by the current user's FQN and team FQNs.
  • Add q?: string — used by the list page free-text search filter.
  • Broaden status?: TaskStatusstatus?: TaskStatus | TaskStatus[] to match how the list page passes a multi-select array from the status filter dropdown.
  • Broaden accessType?: DataAccessTypeaccessType?: DataAccessType | DataAccessType[] for the same reason.

@anuj-kumary anuj-kumary self-assigned this Jun 10, 2026
@anuj-kumary anuj-kumary requested a review from a team as a code owner June 10, 2026 05:02
@anuj-kumary anuj-kumary added UI UI specific issues safe to test Add this label to run secure Github workflows on PRs labels Jun 10, 2026
@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

✅ PR checks passed

The linked issue has a description and all required Shipping project fields set. Thanks!

@github-actions

Copy link
Copy Markdown
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 62%
62.74% (67165/107036) 43.99% (37063/84242) 46.32% (11399/24605)

@sonarqubecloud

Copy link
Copy Markdown

@anuj-kumary anuj-kumary enabled auto-merge (squash) June 10, 2026 06:44
@github-actions

Copy link
Copy Markdown
Contributor

🟡 Playwright Results — all passed (13 flaky)

✅ 4271 passed · ❌ 0 failed · 🟡 13 flaky · ⏭️ 88 skipped

Shard Passed Failed Flaky Skipped
✅ Shard 1 301 0 0 4
✅ Shard 2 806 0 0 9
🟡 Shard 3 806 0 2 8
🟡 Shard 4 840 0 3 12
🟡 Shard 5 720 0 1 47
🟡 Shard 6 798 0 7 8
🟡 13 flaky test(s) (passed on retry)
  • Features/Table.spec.ts › Table pagination with sorting should works (shard 3, 1 retry)
  • Features/Tasks/TaskNavigation.spec.ts › navigating to /table/TASK-XXXXX should show 404 (invalid URL pattern) (shard 3, 1 retry)
  • Pages/CustomProperties.spec.ts › Markdown (shard 4, 1 retry)
  • Pages/CustomProperties.spec.ts › Set & Update all CP types on apiCollection (shard 4, 1 retry)
  • Pages/DataContractInheritance.spec.ts › Edit Inherited Contract - Creates new asset contract instead of modifying parent (shard 4, 1 retry)
  • Pages/ExplorePageRightPanel_KnowledgeCenter.spec.ts › Should remove user owner for knowledgeCenter (shard 5, 2 retries)
  • Pages/Glossary.spec.ts › Drag and Drop Glossary Term (shard 6, 1 retry)
  • Pages/Lineage/LineageFilters.spec.ts › Verify lineage service filter selection (shard 6, 1 retry)
  • Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)
  • Pages/Lineage/LineageRightPanel.spec.ts › Verify custom properties tab IS visible for supported type: searchIndex (shard 6, 1 retry)
  • Pages/Lineage/PlatformLineage.spec.ts › Verify domain platform view (shard 6, 1 retry)
  • Pages/ODCSImportExport.spec.ts › Multi-object ODCS contract - object selector shows all schema objects (shard 6, 1 retry)
  • Pages/Tags.spec.ts › Verify system classification term counts (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@anuj-kumary anuj-kumary merged commit 52f7925 into main Jun 10, 2026
51 of 52 checks passed
@anuj-kumary anuj-kumary deleted the issue-#28893 branch June 10, 2026 07:45
@gitar-bot

gitar-bot Bot commented Jun 10, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Adds missing assignee and query parameters to the DAR list filter and updates status and accessType fields to support array types. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ListDataAccessRequestsParams missing fields and incorrect scalar types for status and accessType

3 participants