fix(test): fix SearchSettings spec#28897
Merged
Merged
Conversation
Register waitForResponse before the slider interaction so a fast preview response is never missed. Re-expand the name.ngram panel after save since re-render can collapse it. Use hardcoded default boost (1) instead of reading from the initial API response to simplify the assertion. Also move status validation after awaiting the response so non-200 errors surface with a clear failure instead of a timeout. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
✅ PR checks passedThe linked issue has a description and all required Shipping project fields set. Thanks! |
Rohit0301
approved these changes
Jun 10, 2026
Contributor
|
Contributor
🟡 Playwright Results — all passed (14 flaky)✅ 4270 passed · ❌ 0 failed · 🟡 14 flaky · ⏭️ 88 skipped
🟡 14 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
Code Review ✅ ApprovedResolves the flaky n-gram revert test in the SearchSettings spec by ensuring the preview panel correctly refreshes after field weight updates or restoring defaults. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
aniketkatkar97
pushed a commit
that referenced
this pull request
Jun 10, 2026
Register waitForResponse before the slider interaction so a fast preview response is never missed. Re-expand the name.ngram panel after save since re-render can collapse it. Use hardcoded default boost (1) instead of reading from the initial API response to simplify the assertion. Also move status validation after awaiting the response so non-200 errors surface with a clear failure instead of a timeout. Co-authored-by: Satender K <satender.kumar@getcollate.io> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



fixes: #27946
Describe your changes: I fixed a bug in the search settings preview where reverting a field weight (e.g. name.ngram from 5 back to 1) or clicking "Restore Defaults" would leave the preview panel frozen on the previous state instead of re-fetching with the updated config.
Type of change:
High-level design:
N/A — small change.
Tests:
Use cases covered
Unit tests
Backend integration tests
Ingestion integration tests
Playwright (UI) tests
Manual testing performed
UI screen recording / screenshots:
Not applicable.
Checklist:
Fixes <issue-number>: <short explanation>Fixes #<issue-number>above.Summary by Gitar
SearchSettings.spec.tsto improve reliability ofwaitForResponselisteners during preview updates.n-gramweight to a static default of1instead of tracking initial state, ensuring predictable assertion outcomes.This will update automatically on new commits.