fix(ingestion/mysql): default unknown stored-procedure language to SQL instead of None#28898
Merged
Conversation
The MySQL stored-procedure language lookup used STORED_PROC_LANGUAGE_MAP.get(language) with no default, so any ROUTINE_BODY value other than "SQL" (e.g. "EXTERNAL" on MySQL 8) resolved to None and the routine was recorded with no language. Add DEFAULT_STORED_PROC_LANGUAGE (Language.SQL) next to the map in models.py and use it as the .get() fallback in metadata.py, so an unmapped value falls back to SQL — which MySQL routines are in practice. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
✅ PR checks passedThe linked issue has a description and all required Shipping project fields set. Thanks! |
github-actions
Bot
added
Ingestion
safe to test
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent MySQL stored procedure/function ingestion from recording a None language when MySQL reports a routine language/body not present in STORED_PROC_LANGUAGE_MAP, by defaulting to Language.SQL.
Changes:
- Introduces
DEFAULT_STORED_PROC_LANGUAGE = Language.SQLin MySQL models. - Updates stored procedure request creation to use
STORED_PROC_LANGUAGE_MAP.get(..., DEFAULT_STORED_PROC_LANGUAGE).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| ingestion/src/metadata/ingestion/source/database/mysql/models.py | Adds a default stored-procedure language constant alongside the language map. |
| ingestion/src/metadata/ingestion/source/database/mysql/metadata.py | Uses the new default language when mapping the routine language into StoredProcedureCode. |
Contributor
🟡 Playwright Results — all passed (11 flaky)✅ 4272 passed · ❌ 0 failed · 🟡 11 flaky · ⏭️ 88 skipped
🟡 11 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
2 tasks
…ROUTINE_BODY The previous fallback was unreachable: MYSQL_GET_ROUTINES never selected the routine body, so MysqlRoutine.language was always the model default "SQL" and the language map never saw other values. - queries.py: select ROUTINE_BODY AS language so the DB-reported language actually flows into MysqlRoutine - models.py: map "EXTERNAL" to Language.External (MySQL 8 reports external routine bodies) and keep Language.SQL as the fallback for unknown values - test_mysql.py: cover SQL/EXTERNAL/unknown language mapping through yield_stored_procedure(), and add the language column to the existing get_stored_procedures mock rows Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
mohittilala
approved these changes
Jun 10, 2026
Code Review ✅ ApprovedUpdates MySQL stored procedure ingestion to default unknown languages to SQL, preventing incorrect None values for non-SQL routine bodies. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix ##28844
Description
When ingesting MySQL stored procedures and functions, the connector mapped
the routine's reported language through
STORED_PROC_LANGUAGE_MAP, which onlycontains a single entry for
"SQL". The lookup used.get()with no default,so any other value returned by MySQL resolved to
None, and the storedprocedure was recorded with no language — silently, with no log message.
MySQL 8 can report
ROUTINE_BODY = 'EXTERNAL'or other non-SQL bodies, whichtriggered this case.
Current Behaviour
STORED_PROC_LANGUAGE_MAP.get(stored_procedure.language)returnsNoneforany reported language that is not exactly
"SQL", so the routine is ingestedwith
language=None.Expected Behaviour
Language.SQL(MySQLroutines are SQL in practice) rather than
None.Type of change:
High-level design:
N/A — small change.
Tests:
Use cases covered
Unit tests
Backend integration tests
Ingestion integration tests
Playwright (UI) tests
Manual testing performed
UI screen recording / screenshots:
Not applicable.
Checklist:
Fixes <issue-number>: <short explanation>Fixes #<issue-number>above.