Skip to content

(playwright): fix flaky online users & Teams spec#28899

Merged
harsh-vador merged 2 commits into
mainfrom
fix-flaky-online-users.spec
Jun 10, 2026
Merged

(playwright): fix flaky online users & Teams spec#28899
harsh-vador merged 2 commits into
mainfrom
fix-flaky-online-users.spec

Conversation

@harsh-vador

@harsh-vador harsh-vador commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Describe your changes:

  • Fixed online users spec flakiness by adding a test.slow since that particular test block involved large multiple operations.
  • Fixed teams spec by a strict api 'GET' endpoint url matching

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

High-level design:

N/A — small change.

Tests:

Use cases covered

Unit tests

Backend integration tests

Ingestion integration tests

Playwright (UI) tests

Manual testing performed

UI screen recording / screenshots:

Not applicable.

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • My PR is linked to a GitHub issue via Fixes #<issue-number> above.
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
  • For UI changes: I attached a screen recording and/or screenshots above.
  • I have added tests (unit / integration / Playwright as applicable) and listed them above.

Summary by Gitar

  • Test stability:
    • Added test.slow() to the OnlineUsers.spec.ts test to accommodate multiple logins and navigation steps.
    • Refactored Teams.spec.ts to use explicit PATCH and GET request interceptors instead of a generic wildcard listener to ensure reliable synchronization.

This will update automatically on new commits.

@harsh-vador harsh-vador self-assigned this Jun 10, 2026
@harsh-vador harsh-vador requested a review from a team as a code owner June 10, 2026 05:41
@harsh-vador harsh-vador added safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch labels Jun 10, 2026
@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

  • No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

@harsh-vador harsh-vador changed the title (playwright): fix flaky online users spec (playwright): fix flaky online users & Teams spec Jun 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 62%
62.74% (67165/107036) 43.99% (37063/84242) 46.32% (11399/24605)

@sonarqubecloud

Copy link
Copy Markdown

@harsh-vador harsh-vador enabled auto-merge (squash) June 10, 2026 06:39
@github-actions

github-actions Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

🟡 Playwright Results — all passed (13 flaky)

✅ 4271 passed · ❌ 0 failed · 🟡 13 flaky · ⏭️ 88 skipped

Shard Passed Failed Flaky Skipped
🟡 Shard 1 299 0 2 4
🟡 Shard 2 802 0 4 9
🟡 Shard 3 806 0 2 8
🟡 Shard 4 841 0 2 12
🟡 Shard 5 720 0 1 47
🟡 Shard 6 803 0 2 8
🟡 13 flaky test(s) (passed on retry)
  • Features/CustomizeDetailPage.spec.ts › Ml Model - customization should work (shard 1, 1 retry)
  • Features/CustomizeDetailPage.spec.ts › Glossary Term - customization should work (shard 1, 1 retry)
  • Features/DataQuality/TestCaseImportExportE2eFlow.spec.ts › Admin: Complete export-import-validate flow (shard 2, 1 retry)
  • Features/DataQuality/TestCaseImportExportE2eFlow.spec.ts › EditAll User: Complete export-import-validate flow (shard 2, 1 retry)
  • Features/DataQuality/TestCaseResultPermissions.spec.ts › User with only VIEW cannot PATCH results (shard 2, 1 retry)
  • Features/Glossary/GlossaryWorkflow.spec.ts › should start term as Draft when glossary has reviewers (shard 2, 2 retries)
  • Features/KnowledgeCenter.spec.ts › Knowledge Center page (shard 3, 1 retry)
  • Features/RTL.spec.ts › Verify Following widget functionality (shard 3, 1 retry)
  • Pages/CustomProperties.spec.ts › Should display custom properties for apiCollection in right panel (shard 4, 1 retry)
  • Pages/DataContracts.spec.ts › Create Data Contract and validate for MlModel (shard 4, 1 retry)
  • Pages/ExplorePageRightPanel_KnowledgeCenter.spec.ts › Should remove user owner for knowledgeCenter (shard 5, 1 retry)
  • Pages/Lineage/DataAssetLineage.spec.ts › Column lineage for dashboardDataModel -> table (shard 6, 1 retry)
  • Pages/Lineage/LineageFilters.spec.ts › Verify lineage schema filter selection (shard 6, 1 retry)

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

@harsh-vador harsh-vador merged commit 1bf2c9a into main Jun 10, 2026
56 of 60 checks passed
@harsh-vador harsh-vador deleted the fix-flaky-online-users.spec branch June 10, 2026 11:08
@gitar-bot

gitar-bot Bot commented Jun 10, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Increases timeout for the online users spec and implements strict API URL matching for the teams spec to resolve intermittent test flakiness. No issues found.

Options

Display: compact → Showing less information.

Comment with these commands to change:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@github-actions

Copy link
Copy Markdown
Contributor

Changes have been cherry-picked to the 1.13 branch.

@github-actions

Copy link
Copy Markdown
Contributor

Failed to cherry-pick changes to the 1.12.11 branch.
Please cherry-pick the changes manually.
You can find more details here.

github-actions Bot pushed a commit that referenced this pull request Jun 10, 2026
* (playwright): fix flaky online users spec

* fix flaky teams spec

(cherry picked from commit 1bf2c9a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs To release Will cherry-pick this PR into the release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants