Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8022 +/- ##
=========================================
Coverage 90.16% 90.17%
+ Complexity 7484 7483 -1
=========================================
Files 836 836
Lines 22562 22562
Branches 2237 2237
=========================================
+ Hits 20344 20345 +1
+ Misses 1515 1513 -2
- Partials 703 704 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…emconv-incubating to v1.39.0-alpha
renovate
bot
force-pushed
the
renovate/io.opentelemetry.semconv-opentelemetry-semconv-incubating-1.x
branch
from
ca9e0e9 to
6b0604a
Compare
renovate
bot
changed the title
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
jkwatson
deleted the
renovate/io.opentelemetry.semconv-opentelemetry-semconv-incubating-1.x
branch
| } | ||
| if (grpcStatusCode != null) { | ||
| return Attributes.of(SemConvAttributes.RPC_GRPC_STATUS_CODE, grpcStatusCode); | ||
| return Attributes.of(SemConvAttributes.RPC_RESPONSE_STATUS_CODE, grpcStatusCode.name()); |
There was a problem hiding this comment.
@jkwatson did you clock this change? Its essentially a breaking change to our internal telemetry, but its understood if you choose InternalTelemetryVersion.LATEST, that the instrumentation will change as we keep up with changes from the still-evolving semantic-conventions.
cc @open-telemetry/java-approvers for visibility.
There was a problem hiding this comment.
whoops. No, I hadn't noticed you had made some adjustments to the PR. If you're fine with this, I'm also fine with it.
2 participants
This PR contains the following updates:
1.37.0-alpha→1.39.0-alphaConfiguration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.