opentelemetry-sdk: sketch of an OpAMP integration#4646
Conversation
|
This PR has been automatically marked as stale because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 days of this comment. |
|
This PR has been automatically marked as stale because it has not had any activity for 14 days. It will be closed if no further activity occurs within 14 days of this comment. |
f2f49fd to
579da8c
Compare
|
|
||
| # OpAMP is a system created to configure OpenTelemetry SDKs with a remote config. | ||
| # This is different than other init helpers because setting up OpAMP requires distro | ||
| # provided code as it's not strictly specified. We call OpAMP init before other code |
There was a problem hiding this comment.
In my distro I initialize the OpAMP client after the sdk has been setup but can't exclude other scenarios
There was a problem hiding this comment.
Should we add this a SIG topic to get the execution order?
There was a problem hiding this comment.
I've renamed the entry point to pre_sdk_init_function so that we can add a post_sdk_init_function if required
pmcollins
left a comment
There was a problem hiding this comment.
Thanks for doing this. Added a comment.
|
|
||
| # OpAMP is a system created to configure OpenTelemetry SDKs with a remote config. | ||
| # This is different than other init helpers because setting up OpAMP requires distro | ||
| # provided code as it's not strictly specified. We call OpAMP init before other code |
There was a problem hiding this comment.
Should we add this a SIG topic to get the execution order?
23f3ff7 to
830fd1b
Compare
1691294 to
4774c5b
Compare
|
Added both a pre and post init hook. Failures in the tests looks unrelated but need to take a closer look at them since they are reproducible on CI only on this branch. |
|
Thanks for the PR! Just a heads-up: we no longer update Please add the appropriate changelog fragment for this change instead of editing |
f85dc04 to
12143fd
Compare
Description
This is a basic integration for setting up OpAMP in the sdk configurator.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: