-
Notifications
You must be signed in to change notification settings - Fork 874
feat(config): exporter plugin loading via entry points for declarative config #5128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MikeGoldsmith
wants to merge
7
commits into
open-telemetry:main
Choose a base branch
from
MikeGoldsmith:mike/config-exporter-plugin-loading
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f2d964b
add exporter plugin loading to declarative config for all three signals
MikeGoldsmith 25e9257
revert models.py changes, use raw dicts without modifying codegen
MikeGoldsmith 25b9577
merge upstream/main
MikeGoldsmith 4e15e8e
update exporter plugin loading to use additional_properties
MikeGoldsmith bdadd23
merge upstream/main
MikeGoldsmith 8b9128c
merge upstream/main
MikeGoldsmith cb1992c
address review: consistent console exporter in registry, merge main
MikeGoldsmith File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -137,14 +137,28 @@ def _create_otlp_grpc_span_exporter( | |
| ) | ||
|
|
||
|
|
||
| _SPAN_EXPORTER_REGISTRY: dict = { | ||
| "otlp_http": _create_otlp_http_span_exporter, | ||
| "otlp_grpc": _create_otlp_grpc_span_exporter, | ||
| "console": lambda _: ConsoleSpanExporter(), | ||
|
tammy-baylis-swi marked this conversation as resolved.
|
||
| } | ||
|
|
||
|
|
||
| def _create_span_exporter(config: SpanExporterConfig) -> SpanExporter: | ||
| """Create a span exporter from config.""" | ||
| if config.otlp_http is not None: | ||
| return _create_otlp_http_span_exporter(config.otlp_http) | ||
| if config.otlp_grpc is not None: | ||
| return _create_otlp_grpc_span_exporter(config.otlp_grpc) | ||
| if config.console is not None: | ||
| return ConsoleSpanExporter() | ||
| """Create a span exporter from config. | ||
|
|
||
| Known exporter types are checked via typed fields on the SpanExporter | ||
| dataclass. Unknown exporter names captured in additional_properties | ||
| by the @_additional_properties decorator are loaded via the | ||
| ``opentelemetry_traces_exporter`` entry point group. | ||
| """ | ||
| for name, factory in _SPAN_EXPORTER_REGISTRY.items(): | ||
| value = getattr(config, name, None) | ||
| if value is not None: | ||
| return factory(value) | ||
| if config.additional_properties: | ||
| name = next(iter(config.additional_properties)) | ||
| return load_entry_point("opentelemetry_traces_exporter", name)() | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should the unknown/entrypoint exporters be called with an argument? Looks like the known exporters are. |
||
| raise ConfigurationError( | ||
| "No exporter type specified in span exporter config. " | ||
| "Supported types: otlp_http, otlp_grpc, console." | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is otlp file development exporters? Are we supporting these now as part of this pr?