Load app-bundled internal hooks from Codex Desktop#27953
Open
abhinav-oai wants to merge 1 commit into
Open
Conversation
abhinav-oai
force-pushed
the
codex/minimal-app-bundled-hooks
branch
from
d37a18e to
12e33bb
Compare
abhinav-oai
changed the title
abhinav-oai
force-pushed
the
codex/minimal-app-bundled-hooks
branch
7 times, most recently
from
76ad450 to
e43bbf0
Compare
abhinav-oai
added a commit
that referenced
this pull request
Jun 13, 2026
This was referenced Jun 14, 2026
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aaa37a6218
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
abhinav-oai
force-pushed
the
codex/minimal-app-bundled-hooks
branch
from
aaa37a6 to
0b8aa16
Compare
abhinav-oai
changed the base branch from
main
to
codex/desktop-distribution-discovery
abhinav-oai
commented
Jun 15, 2026
Comment on lines
-697
to
-721
| let hook_name = match run.event_name { | ||
| HookEventName::PreToolUse => "PreToolUse", | ||
| HookEventName::PermissionRequest => "PermissionRequest", | ||
| HookEventName::PostToolUse => "PostToolUse", | ||
| HookEventName::PreCompact => "PreCompact", | ||
| HookEventName::PostCompact => "PostCompact", | ||
| HookEventName::SessionStart => "SessionStart", | ||
| HookEventName::UserPromptSubmit => "UserPromptSubmit", | ||
| HookEventName::SubagentStart => "SubagentStart", | ||
| HookEventName::SubagentStop => "SubagentStop", | ||
| HookEventName::Stop => "Stop", | ||
| }; | ||
| let hook_source = match run.source { | ||
| HookSource::System => "system", | ||
| HookSource::User => "user", | ||
| HookSource::Project => "project", | ||
| HookSource::Mdm => "mdm", | ||
| HookSource::SessionFlags => "session_flags", | ||
| HookSource::Plugin => "plugin", | ||
| HookSource::CloudRequirements => "cloud_requirements", | ||
| HookSource::CloudManagedConfig => "cloud_managed_config", | ||
| HookSource::LegacyManagedConfigFile => "legacy_managed_config_file", | ||
| HookSource::LegacyManagedConfigMdm => "legacy_managed_config_mdm", | ||
| HookSource::Unknown => "unknown", | ||
| }; |
Collaborator
Author
There was a problem hiding this comment.
threw this cleanup in here, can ignore for review
abhinav-oai
force-pushed
the
codex/minimal-app-bundled-hooks
branch
from
0b8aa16 to
907bd32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
App-bundled internal hooks need to execute the bytes shipped with verified Codex Desktop installations, not mutable copies from the plugin cache. This preserves the cache for ordinary plugin capabilities without letting it become a trust source for internal hooks.
What changed
openai-bundledplugins from the trusted Codex Desktop resource treeStack