Skip to content

[codex] Verify unified-exec relative workdir execution#28132

Open
anp-oai wants to merge 1 commit into
codex/existing-invariant-integration-tests-03-spawn-failure-cleanupfrom
codex/existing-invariant-integration-tests-04-relative-workdir-exec
Open

[codex] Verify unified-exec relative workdir execution#28132
anp-oai wants to merge 1 commit into
codex/existing-invariant-integration-tests-03-spawn-failure-cleanupfrom
codex/existing-invariant-integration-tests-04-relative-workdir-exec

Conversation

@anp-oai

@anp-oai anp-oai commented Jun 13, 2026

Copy link
Copy Markdown
Collaborator

Close the gap where the relative-workdir integration test trusted event metadata without proving the child process used that directory.

Write a marker inside the requested relative workdir, read it from the spawned command, and assert both the lifecycle cwd and model-visible process output.

The focused test and just fix -p codex-core pass. A full just test completed with 10,853 passing and 47 unrelated failures across existing config, permissions, sandbox, timing, and snapshot tests.

@anp-oai anp-oai marked this pull request as ready for review June 13, 2026 23:32
@anp-oai anp-oai requested a review from a team as a code owner June 13, 2026 23:32
@anp-oai anp-oai force-pushed the codex/existing-invariant-integration-tests-03-spawn-failure-cleanup branch from 2834401 to 121c408 Compare June 13, 2026 23:38
anp-oai added a commit that referenced this pull request Jun 13, 2026
Ok(())
}

async fn assert_exec_process_reuses_id_after_spawn_failure(use_remote: bool) -> Result<()> {

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inline into caller

@anp-oai anp-oai force-pushed the codex/existing-invariant-integration-tests-04-relative-workdir-exec branch from b519123 to dec0c76 Compare June 13, 2026 23:52
@anp-oai anp-oai force-pushed the codex/existing-invariant-integration-tests-03-spawn-failure-cleanup branch from 121c408 to 3abaa51 Compare June 14, 2026 00:01
@anp-oai anp-oai force-pushed the codex/existing-invariant-integration-tests-04-relative-workdir-exec branch from dec0c76 to f6bef94 Compare June 14, 2026 00:01
@anp-oai anp-oai force-pushed the codex/existing-invariant-integration-tests-03-spawn-failure-cleanup branch from 3abaa51 to b82fa01 Compare June 14, 2026 00:05
@anp-oai anp-oai force-pushed the codex/existing-invariant-integration-tests-04-relative-workdir-exec branch from f6bef94 to 0151b45 Compare June 14, 2026 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant