[codex] add experimental managed Amazon Bedrock login and logout#28148
Draft
celia-oai wants to merge 2 commits into
Draft
[codex] add experimental managed Amazon Bedrock login and logout#28148celia-oai wants to merge 2 commits into
celia-oai wants to merge 2 commits into
Conversation
56da969 to
1a11fef
Compare
1a11fef to
6161f76
Compare
b7bed3d to
becae52
Compare
becae52 to
edba806
Compare
9fd89f7 to
02699b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The provider-scoped auth stack can report whether Amazon Bedrock is using a Codex-managed API key, but app-server clients still cannot establish or remove that managed credential. This adds an experimental persistence-only account flow while deliberately leaving runtime provider and auth reloading to a later change.
Depends on #27751.
Stack: #27443 → #27689 → #27751 → this PR.
What changed
amazonBedrockvariant to v2account/login/start, including API key and region validationexperimentalApiinitialization capability for managed Bedrock login and logoutmodel_provider = "amazon-bedrock"to the active user config before returningamazon-bedrockThe auth and config writes are intentionally not transactional in this scoped change. Runtime provider/config reload and cross-store rollback are left for follow-up work.
Test plan
just test -p codex-app-server-protocoljust test -p codex-app-serverjust test -p codex-loginjust test -p codex-model-provider