Use PathUri in filesystem permission paths for exec-server#28165
Merged
Conversation
anp-oai
added a commit
that referenced
this pull request
Jun 14, 2026
anp-oai
commented
Jun 14, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 14, 2026
anp-oai
commented
Jun 14, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 14, 2026
anp-oai
commented
Jun 14, 2026
anp-oai
commented
Jun 14, 2026
anp-oai
commented
Jun 14, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 14, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 15, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 15, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 15, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 15, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 15, 2026
anp-oai
added a commit
that referenced
this pull request
Jun 15, 2026
37cf3ec to
df1275c
Compare
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: df1275c175
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
anp-oai
added a commit
that referenced
this pull request
Jun 15, 2026
a63db3a to
76e6145
Compare
pakrym-oai
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Progress towards letting app-server and exec-server run on different platforms, specifically for sandbox configuration.
What
AbsolutePathBuffor now.AbsolutePathBuforPathUridirectly where needed.PathUrithroughout exec-server filesystem protocol and trait boundaries.Fromfor conversion to path URIs andTryFromfor fallible conversion to absolute paths through the generic type hierarchy.