Skip to content

Use PathUri in filesystem permission paths for exec-server#28165

Merged
anp-oai merged 20 commits into
mainfrom
codex/generic-filesystem-path
Jun 15, 2026
Merged

Use PathUri in filesystem permission paths for exec-server#28165
anp-oai merged 20 commits into
mainfrom
codex/generic-filesystem-path

Conversation

@anp-oai

@anp-oai anp-oai commented Jun 14, 2026

Copy link
Copy Markdown
Collaborator

Why

Progress towards letting app-server and exec-server run on different platforms, specifically for sandbox configuration.

What

  • Make the filesystem path containment hierarchy generic, defaulting to AbsolutePathBuf for now.
  • Have clients specify AbsolutePathBuf or PathUri directly where needed.
  • Use PathUri throughout exec-server filesystem protocol and trait boundaries.
  • Implement From for conversion to path URIs and TryFrom for fallible conversion to absolute paths through the generic type hierarchy.

anp-oai added a commit that referenced this pull request Jun 14, 2026
@anp-oai anp-oai changed the title Make filesystem permission paths generic Use PathUri in filesystem permission paths for exec-server Jun 14, 2026
Comment thread codex-rs/file-system/src/lib.rs Outdated
anp-oai added a commit that referenced this pull request Jun 14, 2026
Comment thread codex-rs/exec-server/src/fs_sandbox.rs Outdated
anp-oai added a commit that referenced this pull request Jun 14, 2026
Comment thread codex-rs/exec-server/src/fs_sandbox.rs Outdated
Comment thread codex-rs/exec-server/src/protocol.rs Outdated
Comment thread codex-rs/tools/src/tool_call.rs Outdated
anp-oai added a commit that referenced this pull request Jun 14, 2026
anp-oai added a commit that referenced this pull request Jun 15, 2026
@anp-oai anp-oai marked this pull request as ready for review June 15, 2026 04:13
@anp-oai anp-oai requested a review from a team as a code owner June 15, 2026 04:13
anp-oai added a commit that referenced this pull request Jun 15, 2026
anp-oai added a commit that referenced this pull request Jun 15, 2026
anp-oai added a commit that referenced this pull request Jun 15, 2026
anp-oai added a commit that referenced this pull request Jun 15, 2026
anp-oai added a commit that referenced this pull request Jun 15, 2026
@anp-oai anp-oai force-pushed the codex/generic-filesystem-path branch from 37cf3ec to df1275c Compare June 15, 2026 04:14

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: df1275c175

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/protocol/Cargo.toml Outdated
anp-oai added a commit that referenced this pull request Jun 15, 2026
@anp-oai anp-oai force-pushed the codex/generic-filesystem-path branch from a63db3a to 76e6145 Compare June 15, 2026 14:52
@anp-oai anp-oai enabled auto-merge (squash) June 15, 2026 23:44
@anp-oai anp-oai merged commit 46f1793 into main Jun 15, 2026
31 checks passed
@anp-oai anp-oai deleted the codex/generic-filesystem-path branch June 15, 2026 23:55
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants