Skip to content

Support staging OAuth client ID overrides#28257

Merged
apanasenko-oai merged 2 commits into
mainfrom
codex/staging-oauth-client-id
Jun 15, 2026
Merged

Support staging OAuth client ID overrides#28257
apanasenko-oai merged 2 commits into
mainfrom
codex/staging-oauth-client-id

Conversation

@apanasenko-oai

Copy link
Copy Markdown
Collaborator

Summary

  • allow app-server ChatGPT login to use a configured OAuth client ID
  • reuse the same client ID for refresh and revoke requests
  • cover staging login, refresh, and revoke request payloads

Tests

  • just test -p codex-login
  • just test -p codex-app-server login_account_chatgpt_uses_debug_oauth_overrides
  • just test -p codex-login logout_with_revoke_revokes_refresh_token_then_removes_auth
  • just fix -p codex-login
  • just fix -p codex-app-server
  • just fmt

@apanasenko-oai apanasenko-oai marked this pull request as ready for review June 15, 2026 05:48

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c0094f3843

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread codex-rs/login/src/auth/manager.rs
Comment thread codex-rs/login/tests/suite/auth_refresh.rs
Comment thread codex-rs/login/src/auth/revoke.rs
@apanasenko-oai apanasenko-oai merged commit 336f907 into main Jun 15, 2026
31 checks passed
@apanasenko-oai apanasenko-oai deleted the codex/staging-oauth-client-id branch June 15, 2026 17:56
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants