feat(exceptions): add session exception classes for better error hand…#2275
Closed
HemanthIITJ wants to merge 1 commit intoopenai:mainfrom
Closed
feat(exceptions): add session exception classes for better error hand…#2275HemanthIITJ wants to merge 1 commit intoopenai:mainfrom
HemanthIITJ wants to merge 1 commit intoopenai:mainfrom
Conversation
…ling Add dedicated exception classes for session-related errors to provide clearer error messages and enable more specific exception handling. - Add SessionError base class with session_id tracking - Add SessionNotFoundError for missing session scenarios - Add SessionSerializationError for serialization failures - Export all new exceptions from package __init__.py - Add comprehensive tests for all session exceptions
Member
|
Thanks for sending this PR! However, it seems these exceptions are not used by sessions store implementation. Thus, adding the new ones does not make any sense. If you have a certain use case with granular error types with sessions, please start a discussion issue first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ling
Add dedicated exception classes for session-related errors to provide clearer error messages and enable more specific exception handling.