fix(mcp): reset AsyncExitStack after cleanup for reconnect (#618)#2882
Open
Abdeltoto wants to merge 1 commit intoopenai:mainfrom
Open
fix(mcp): reset AsyncExitStack after cleanup for reconnect (#618)#2882Abdeltoto wants to merge 1 commit intoopenai:mainfrom
Abdeltoto wants to merge 1 commit intoopenai:mainfrom
Conversation
AsyncExitStack cannot be reused after aclose(). Second connect()/reconnect() must use a fresh stack. Clear server_initialize_result on teardown. Add regression test for connect->cleanup->connect->cleanup. Made-with: Cursor
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
\AsyncExitStack\ cannot be reused after \�close(). After \cleanup(), a second \connect()\ (e.g. \MCPServerManager.reconnect()) would call \enter_async_context\ on a closed stack, which is invalid and can contribute to resource leaks / shutdown warnings (see #618).
Change
Testing
uff check\ on touched files: OK.
Fixes Resource tracker warning (leaked semaphores) with MCPServerStdio #618
Made with Cursor