Conversation
* commit '45e3974d59dbea6d29b757d7f6bd4d00f8ca840b': Update ofAppEGLWindow.cpp
danoli3
left a comment
There was a problem hiding this comment.
Quick review looks good need to check if no regression
|
Looks like a big change to quite a few files. |
|
I keep testing the different examples in macOS. All good so far. I cherry picked ancient code so will paste over latest formatting soon Some core changes to ofFbo / ofGLProgrammableRender / ofShadow / ofMaterial / ofGLUtils etc Critical changes to support Emscripten though |
|
|
||
| void bind(const ofFbo & fbo); | ||
| #ifndef TARGET_OPENGLES | ||
| #if !defined(TARGET_OPENGLES) || defined(GL_ES_VERSION_3_0) |
There was a problem hiding this comment.
one question here:
if TARGET_OPENGLES is also set when GL_ES_VERSION_3_0 is true, would this avoid changing lots of if defined in core? or am I missing something?
There was a problem hiding this comment.
Yes it pretty much would always be defined then, need to modify this to is defined and defined enabled like TARGET_OPENGLES_3 that can be user controlled
So far it builds though for iOS and runs with ES3 or ES2 or even ES1 based on main.mm / window
OpenGLES 3 target is best though for dawn or ANGLE auto to Metal / Vulkan btw
Added an undef if needed. OpenGL ES1 and ES2 should be easily controlled now if required. It was still working with ES1 and ES2 on iOS tests though. More strict control for older projects though |
trying 3d primitive example in OpenGL 3.2 (programmable) getting the same error I was getting on emscripten is that happening on master @ofTheo 3DPrimitivesExample |



OpenGLES 3