Skip to content

Implementation of point detectors#3757

Open
GuySten wants to merge 164 commits into
openmc-dev:developfrom
GuySten:point-detector
Open

Implementation of point detectors#3757
GuySten wants to merge 164 commits into
openmc-dev:developfrom
GuySten:point-detector

Conversation

@GuySten
Copy link
Copy Markdown
Contributor

@GuySten GuySten commented Jan 29, 2026 •
edited
Loading

Description

This PR implements point detectors in openmc.
It is based on the work done in #3109 but with classical kinematics.

Currently only continuous energy neutrons are supported.

This PR depends on #3881, #3935.

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 18) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

Your Name and others added 30 commits August 27, 2025 18:29
Implement get_pdf functionality
06ae298
@itay-space @GuySten
Update include/openmc/distribution.h
78d841e 
Co-authored-by: GuySten <62616591+GuySten@users.noreply.github.com>
@itay-space @GuySten
Update include/openmc/particle_data.h
33a27a9 
Co-authored-by: GuySten <62616591+GuySten@users.noreply.github.com>
@itay-space @GuySten
Update include/openmc/particle_data.h
d968875 
Co-authored-by: GuySten <62616591+GuySten@users.noreply.github.com>
@itay-space @GuySten
Update src/physics.cpp
3b896c0 
Co-authored-by: GuySten <62616591+GuySten@users.noreply.github.com>
@itay-space @GuySten
Update src/physics.cpp
c034bff 
Co-authored-by: GuySten <62616591+GuySten@users.noreply.github.com>
@itay-space @GuySten
Update src/physics.cpp
a5d2f4c 
Co-authored-by: GuySten <62616591+GuySten@users.noreply.github.com>
Cleaning some code
ca5b44e
Resolving conversations
eed8b1c
@GuySten
cosmetic fixes
f2ecdd4
@GuySten
Merge branch 'develop' into get_pdf
71d5fa2
@GuySten
simplified code significantly
c3b4d82
@itay-space @GuySten
Update src/distribution_angle.cpp
78a33cc 
Co-authored-by: GuySten <62616591+GuySten@users.noreply.github.com>
@GuySten
ran clang format
6d70d39
@GuySten
fixes
acfd402
@GuySten
cosmetics
98ca32e
using openmc's fatal_error
26d2a56
Use accessors in powerlaw
7abe69c
clausing error for different distributions
d183cce
fixing function signature
37b41c4
@Eliezer214 @GuySten
Update include/openmc/angle_energy.h
007dcf5 
Co-authored-by: GuySten <62616591+GuySten@users.noreply.github.com>
@Eliezer214 @GuySten
Update include/openmc/distribution_angle.h
ebebb7a 
Co-authored-by: GuySten <62616591+GuySten@users.noreply.github.com>
@Eliezer214 @GuySten
Update include/openmc/secondary_thermal.h
0239c1f 
Co-authored-by: GuySten <62616591+GuySten@users.noreply.github.com>
@Eliezer214 @GuySten
Update include/openmc/angle_energy.h
225f837 
Co-authored-by: GuySten <62616591+GuySten@users.noreply.github.com>
@Eliezer214 @GuySten
Update include/openmc/reaction_product.h
fa22e14 
Co-authored-by: GuySten <62616591+GuySten@users.noreply.github.com>
@itay-space @GuySten
Update src/reaction_product.cpp
a0678c9 
Co-authored-by: GuySten <62616591+GuySten@users.noreply.github.com>
@itay-space @GuySten
Update src/thermal.cpp
e590d82 
Co-authored-by: GuySten <62616591+GuySten@users.noreply.github.com>
@itay-space @GuySten
Update include/openmc/secondary_thermal.h
1b1134e 
Co-authored-by: GuySten <62616591+GuySten@users.noreply.github.com>
@itay-space @GuySten
Update src/secondary_uncorrelated.cpp
5c348f1 
Co-authored-by: GuySten <62616591+GuySten@users.noreply.github.com>
@itay-space @GuySten
Update src/secondary_thermal.cpp
203a191 
Co-authored-by: GuySten <62616591+GuySten@users.noreply.github.com>
@GuySten
Copy link
Copy Markdown
Contributor Author

GuySten commented May 11, 2026

Some tests from the paper using this PR:

U235 test:

image

He4 test:

image

@GuySten GuySten changed the title Testing point detectors Implementation of point detectors May 11, 2026
@GuySten GuySten marked this pull request as ready for review May 11, 2026 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulromano paulromano Awaiting requested review from paulromano paulromano is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Point Detector

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GuySten @itay-space @Eliezer214 @zxkjack123