Skip to content

[FEATURE] Add an option to turn on and off the certificate validation of llm connectors #4394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akolarkunnu wants to merge 5 commits into
base: main
Choose a base branch
from
+34 −7
Open

[FEATURE] Add an option to turn on and off the certificate validation of llm connectors #4394

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2f5e82f
[FEATURE] Add an option to turn on and off the certificate validation…
akolarkunnu Nov 4, 2025
3027319
Merge branch 'opensearch-project:main' into sslverification
akolarkunnu Dec 7, 2025
564d401
[FEATURE] Add an option to turn on and off the certificate validation…
akolarkunnu Dec 7, 2025
de4ce11
Merge branch 'sslverification' of https://github.com/akolarkunnu/ml-c…
akolarkunnu Dec 7, 2025
2d657e9
Fixed coderabbitai comments
akolarkunnu Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions common/src/main/java/org/opensearch/ml/common/httpclient/MLHttpClientFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,10 @@
import java.time.Duration;

import lombok.extern.log4j.Log4j2;
import software.amazon.awssdk.http.SdkHttpConfigurationOption;
import software.amazon.awssdk.http.async.SdkAsyncHttpClient;
import software.amazon.awssdk.http.nio.netty.NettyNioAsyncHttpClient;
import software.amazon.awssdk.utils.AttributeMap;

@Log4j2
public class MLHttpClientFactory {
Expand All @@ -20,7 +22,8 @@ public static SdkAsyncHttpClient getAsyncHttpClient(
Duration connectionTimeout,
Duration readTimeout,
int maxConnections,
boolean connectorPrivateIpEnabled
boolean connectorPrivateIpEnabled,
boolean skipSslVerification
) {
return doPrivileged(() -> {
log
Expand All @@ -35,7 +38,9 @@ public static SdkAsyncHttpClient getAsyncHttpClient(
.connectionTimeout(connectionTimeout)
.readTimeout(readTimeout)
.maxConcurrency(maxConnections)
.build();
.buildWithDefaults(
AttributeMap.builder().put(SdkHttpConfigurationOption.TRUST_ALL_CERTIFICATES, skipSslVerification).build()
);
return new MLValidatableAsyncHttpClient(delegate, connectorPrivateIpEnabled);
});
}
Expand Down
5 changes: 4 additions & 1 deletion common/src/test/java/org/opensearch/ml/common/httpclient/MLHttpClientFactoryTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,10 @@ public class MLHttpClientFactoryTests {

@Test
public void test_getSdkAsyncHttpClient_success() {
SdkAsyncHttpClient client = MLHttpClientFactory.getAsyncHttpClient(Duration.ofSeconds(100), Duration.ofSeconds(100), 100, false);
SdkAsyncHttpClient client = MLHttpClientFactory
.getAsyncHttpClient(Duration.ofSeconds(100), Duration.ofSeconds(100), 100, false, false);
assertNotNull(client);
client = MLHttpClientFactory.getAsyncHttpClient(Duration.ofSeconds(100), Duration.ofSeconds(100), 100, false, true);
assertNotNull(client);
}

Expand Down
7 changes: 6 additions & 1 deletion ...rithms/src/main/java/org/opensearch/ml/engine/algorithms/remote/AwsConnectorExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,10 +190,15 @@ protected SdkAsyncHttpClient getHttpClient() {
Duration connectionTimeout = Duration.ofSeconds(super.getConnectorClientConfig().getConnectionTimeout());
Duration readTimeout = Duration.ofSeconds(super.getConnectorClientConfig().getReadTimeout());
Integer maxConnection = super.getConnectorClientConfig().getMaxConnections();
boolean skipSslVerification = false;
if (connector.getParameters() != null && connector.getParameters().containsKey(SKIP_SSL_VERIFICATION)) {
skipSslVerification = Boolean.parseBoolean(connector.getParameters().get(SKIP_SSL_VERIFICATION));
}
this.httpClientRef
.compareAndSet(
null,
MLHttpClientFactory.getAsyncHttpClient(connectionTimeout, readTimeout, maxConnection, connectorPrivateIpEnabled)
MLHttpClientFactory
.getAsyncHttpClient(connectionTimeout, readTimeout, maxConnection, connectorPrivateIpEnabled, skipSslVerification)
);
}
return httpClientRef.get();
Expand Down
7 changes: 6 additions & 1 deletion ...s/src/main/java/org/opensearch/ml/engine/algorithms/remote/HttpJsonConnectorExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,10 +180,15 @@ protected SdkAsyncHttpClient getHttpClient() {
Duration connectionTimeout = Duration.ofSeconds(super.getConnectorClientConfig().getConnectionTimeout());
Duration readTimeout = Duration.ofSeconds(super.getConnectorClientConfig().getReadTimeout());
Integer maxConnection = super.getConnectorClientConfig().getMaxConnections();
boolean skipSslVerification = false;
if (connector.getParameters() != null && connector.getParameters().containsKey(SKIP_SSL_VERIFICATION)) {
skipSslVerification = Boolean.parseBoolean(connector.getParameters().get(SKIP_SSL_VERIFICATION));
}
this.httpClientRef
.compareAndSet(
null,
MLHttpClientFactory.getAsyncHttpClient(connectionTimeout, readTimeout, maxConnection, connectorPrivateIpEnabled)
MLHttpClientFactory
.getAsyncHttpClient(connectionTimeout, readTimeout, maxConnection, connectorPrivateIpEnabled, skipSslVerification)
);
}
return httpClientRef.get();
Expand Down
1 change: 1 addition & 0 deletions ...hms/src/main/java/org/opensearch/ml/engine/algorithms/remote/RemoteConnectorExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@
public interface RemoteConnectorExecutor {

public String RETRY_EXECUTOR = "opensearch_ml_predict_remote";
String SKIP_SSL_VERIFICATION = "skip_ssl_verification";

default void executeAction(String action, MLInput mlInput, ActionListener<MLTaskResponse> actionListener) {
executeAction(action, mlInput, actionListener, null);
Expand Down
Loading