Skip to content

Fix issue setting nextUrl on click of logout button#2040

Closed
cwperks wants to merge 3 commits intoopensearch-project:mainfrom
cwperks:fix-next-url-oidc
Closed

Fix issue setting nextUrl on click of logout button#2040
cwperks wants to merge 3 commits intoopensearch-project:mainfrom
cwperks:fix-next-url-oidc

Conversation

@cwperks
Copy link
Copy Markdown
Member

@cwperks cwperks commented Jul 16, 2024

Description

Opening up a Draft PR that shows a fixes an issue on logout for multiple authentication types (basic + OIDC). When a user clicks the logout button, they will logout of the respective IdP and then land back on the OSD login screen. When the user is on the login page, the url is supposed to contain a nextUrl param which contains the page that the user was most recently visiting in OSD when they explicitly click the logout button.

Category

Bug fix

Issues Resolved

Discovered while investigating: #1823

Testing

This will stay in draft until unit and functional tests are added

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Craig Perkins <cwperx@amazon.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 16, 2024

Codecov Report

❌ Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.39%. Comparing base (c143bce) to head (1a47c48).
⚠️ Report is 88 commits behind head on main.

Files with missing lines Patch % Lines
public/apps/account/utils.tsx 20.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2040   +/-   ##
=======================================
  Coverage   71.39%   71.39%           
=======================================
  Files          97       97           
  Lines        2650     2650           
  Branches      403      402    -1     
=======================================
  Hits         1892     1892           
  Misses        642      642           
  Partials      116      116           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Craig Perkins <cwperx@amazon.com>
@DarshitChanpura
Copy link
Copy Markdown
Member

@cwperks Should this PR be closed?

@cwperks cwperks closed this Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants