Skip to content

HYPERFLEET-1246: Add missing kind field to NodePool creation example#61

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift-hyperfleet:mainfrom
kuudori:HYPERFLEET-1246
Jun 19, 2026
Merged

HYPERFLEET-1246: Add missing kind field to NodePool creation example#61
openshift-merge-bot[bot] merged 1 commit into
openshift-hyperfleet:mainfrom
kuudori:HYPERFLEET-1246

Conversation

@kuudori

@kuudori kuudori commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Added missing kind: "NodePool" to the NodePool creation Swagger example
  • Version bump 1.0.21 → 1.0.22

Test plan

  • ./build-schema.sh passes
  • spectral lint passes with --fail-severity warn
  • Swagger UI shows kind: NodePool in NodePool creation example

…ample

The Swagger UI example for NodePool creation was missing the mandatory
`kind` field, causing users to get a validation error when copying the
example payload.
@openshift-ci openshift-ci Bot requested review from Mischulee and crizzo71 June 18, 2026 19:56
@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 7874e657-4ccd-4361-826d-95d1daf6b36f

📥 Commits

Reviewing files that changed from the base of the PR and between df34900 and 86ceae7.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (5)
  • CHANGELOG.md
  • core/models/nodepool/example_post.tsp
  • main.tsp
  • package.json
  • schemas/core/openapi.yaml
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • openshift-hyperfleet/architecture (manual)
  • openshift-hyperfleet/hyperfleet-api (manual)
  • openshift-hyperfleet/hyperfleet-sentinel (manual)
  • openshift-hyperfleet/hyperfleet-adapter (manual)
  • openshift-hyperfleet/hyperfleet-broker (manual)

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Fixed NodePool creation example to include the required kind field, ensuring proper API request structure.

Walkthrough

Version 1.0.22 patch release. The kind: "NodePool" field was missing from the exampleNodePoolCreateRequest object in core/models/nodepool/example_post.tsp; it is now present. The generated schemas/core/openapi.yaml reflects this addition in the NodePoolCreateRequest example block. All version identifiers are incremented: package.json from 1.0.20 to 1.0.22, main.tsp @info from 1.0.21 to 1.0.22, and openapi.yaml info.version from 1.0.21 to 1.0.22. CHANGELOG.md gains a [1.0.22] section and updated comparison links.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 11
✅ Passed checks (11 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding the missing kind field to NodePool creation example, which is the primary focus of the PR.
Description check ✅ Passed The description is directly related to the changeset, outlining the key fix (adding kind field), version bump, and test verification steps.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Sec-02: Secrets In Log Output ✅ Passed PR modifies only TypeScript specs, YAML, JSON, and Markdown files. No Go code changes. The single Go file (schemas/schemas.go) contains no logging statements and was not modified.
No Hardcoded Secrets ✅ Passed No hardcoded secrets, API keys, tokens, passwords, private keys, or base64-encoded credentials found. All changes are version bumps and placeholder example values.
No Weak Cryptography ✅ Passed No weak cryptographic primitives (MD5, DES, RC4, SHA1-security, ECB, custom crypto) or non-constant-time comparisons detected. PR contains only documentation and version bumps with no crypto code.
No Injection Vectors ✅ Passed PR modifies only TypeSpec declarations and configuration files; no executable code paths contain CWE-89, CWE-78, CWE-79, or CWE-502 injection vectors.
No Privileged Containers ✅ Passed PR modifies API specification and examples only. No Kubernetes manifests, Helm templates, or Dockerfiles introduced. No privilege escalation patterns detected.
No Pii Or Sensitive Data In Logs ✅ Passed PR contains no logging statements. Changes are limited to version bumps and adding kind: "NodePool" to API example payload in TypeSpec, YAML, and documentation files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Comment @coderabbitai help to get the list of available commands and usage tips.

@rafabene

Copy link
Copy Markdown
Contributor

Tip

nit — non-blocking suggestion

Category: Pattern

PR title doesn't follow the commit message standard format HYPERFLEET-XXX - <type>: <subject>. Consider updating to:

HYPERFLEET-1246 - fix: add missing kind field to NodePool creation example

@rafabene

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci

openshift-ci Bot commented Jun 19, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rafabene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 4a55942 into openshift-hyperfleet:main Jun 19, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants