Skip to content

HYPERFLEET-1057 - fix: Update sentinel release name to match e2e name #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ma-hill wants to merge 1 commit into from
Closed

HYPERFLEET-1057 - fix: Update sentinel release name to match e2e name #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion helmfile/helmfile.yaml.gotmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ releases:
- values/base-api.yaml.gotmpl

{{ range .Values.sentinels }}
- name: {{ .name }}
- name: sentinel-{{ .name }}

@sherine-k sherine-k Jun 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ma-hill,
I was thinking about potential impact on (production) environments, if any, that already have used this helmfile.
Is the thinking that we are instructing end-users/partners to destroy the existing sentinels anyway when upgrading to 1.0.0? (openshift-hyperfleet/architecture#157).
So that is why we don't care about this renaming leaving the old resources orphaned and creating new ones?

@rafabene rafabene Jun 19, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tip

nit — non-blocking suggestion

Category: Pattern

This renames the Helm release for all environments (e2e + kind + gcp), which means existing deployments will get orphaned releases under the old names. Consider adding a note under [Unreleased] in CHANGELOG.md:

### Changed

- Sentinel Helm release names now use `sentinel-` prefix (`sentinel-clusters`, `sentinel-nodepools`) to match e2e naming conventions — existing releases under the old names must be manually removed

namespace: {{ $.Values.namespace }}
chart: hyperfleet-sentinel/hyperfleet-sentinel
needs:
Expand Down