Agent-based installer - add static networking support for ISO_NO_REGISTRY mode - #1940
Agent-based installer - add static networking support for ISO_NO_REGISTRY mode#1940bfournie wants to merge 1 commit into
Conversation
Add TUI automation to configure static IPs, hostnames, and DNS via nmtui for agent-based ISO_NO_REGISTRY installations. Creates a NEW NetworkManager connection (rather than editing the existing DHCP one) to ensure --copy-network is triggered by coreos-installer, preserving the static config across reboots. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@bfournie: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
This appears to work well, removing the WIP The install was successfully And can log in via the static IP to all of the nodes |
There was a problem hiding this comment.
a little bit of bikeshedding: the name here doesn't convey properly IMHO the nature of the test. This e2e script applies the first step (by automating the agent TUI, but that's a technical detail) of a test to verify that a network config applied via agent TUI is effectively applied at the end of the installation
| @@ -0,0 +1,165 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Not strictly blocking, but I'd find really useful to have a brief description here about what the script is meant to perform: it will avoid reading all the commands one by one
| # selection. Static IPs are assigned starting at 192.168.111.80 (rendezvous node), | ||
| # incrementing by 1 for each additional node. | ||
| # Requires: AGENT_E2E_TEST_BOOT_MODE=ISO_NO_REGISTRY | ||
| # export AGENT_ISO_NO_REGISTRY_STATIC_NETWORKING=true |
There was a problem hiding this comment.
I am little bit confused here. In the past we implemented the the AGENT_TEST_CASES approach, with the idea of running additional e2e test cases directly within dev-scripts. The bad_dns one also focused on the agent TUI. Rather than defining a new config var, I think it would be better to keep re-using the AGENT_TEST_CASES mechanism.
As mentioned also previously, from a strict point of view of the test, what we need is:
- Modify the network configuration of just one of the nodes, assigning a static IP different from the usual DHCP ones, using the agent TUI
- At the end of installation, verify that the node effectively has been assigned the static IP.
A [[ $AGENT_TEST_CASES =~ "static_ip" ]] may help activating the test when required, and also adding the code where required.
| sudo virsh screenshot "$name" "${OCP_DIR}/${name}_console_screenshot_after_static_networking.ppm" | ||
| echo "Finished configuring static networking for $name" | ||
| done | ||
| } |
There was a problem hiding this comment.
For what regards the e2e tests, it would be sufficient to just modify one of the nodes (maybe using an hard-coded ip). That could also help in reducing the complexity of the test code
Add TUI automation to configure static IPs and hostnames via nmtui for agent-based ISO_NO_REGISTRY installations. Creates a NEW NetworkManager connection (rather than editing the existing DHCP one) to ensure
--copy-networkis triggered by coreos-installer, preserving the static config across reboots.See openshift/assisted-installer-agent#1374