Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion config/v1/types_infrastructure.go
Original file line number Diff line number Diff line change
Expand Up @@ -720,7 +720,7 @@ type AzureResourceTag struct {
}

// AzureCloudEnvironment is the name of the Azure cloud environment
// +kubebuilder:validation:Enum="";AzurePublicCloud;AzureUSGovernmentCloud;AzureChinaCloud;AzureGermanCloud;AzureStackCloud
// +kubebuilder:validation:Enum="";AzurePublicCloud;AzureUSGovernmentCloud;AzureChinaCloud;AzureGermanCloud;AzureStackCloud;AzureUSSecCloud

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that AzureCloudEnvironment enum has existed for a while. Technically, https://github.com/openshift/api/blame/master/config/v1/types_infrastructure.go#L658-L662 should not be allowed to change on day-2. There is no kubebuilder validation for that.

type AzureCloudEnvironment string

const (
Expand All @@ -738,6 +738,9 @@ const (

// AzureStackCloud is the Azure cloud environment used at the edge and on premises.
AzureStackCloud AzureCloudEnvironment = "AzureStackCloud"

// AzureUSSecCloud is the Azure cloud environment for US Government Secret (IL6) workloads.
AzureUSSecCloud AzureCloudEnvironment = "AzureUSSecCloud"
)

// Start: TOMBSTONE
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1517,6 +1517,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
networkResourceGroupName:
description: |-
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1608,6 +1608,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
ipFamily:
default: IPv4
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1593,6 +1593,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
ipFamily:
default: IPv4
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1517,6 +1517,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
networkResourceGroupName:
description: |-
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1608,6 +1608,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
ipFamily:
default: IPv4
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1608,6 +1608,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
ipFamily:
default: IPv4
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1594,6 +1594,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
ipFamily:
default: IPv4
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1368,6 +1368,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
networkResourceGroupName:
description: |-
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1458,6 +1458,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
networkResourceGroupName:
description: |-
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1378,6 +1378,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
networkResourceGroupName:
description: |-
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1354,6 +1354,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
ipFamily:
default: IPv4
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1354,6 +1354,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
networkResourceGroupName:
description: |-
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1360,6 +1360,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
networkResourceGroupName:
description: |-
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1416,6 +1416,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
networkResourceGroupName:
description: |-
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1369,6 +1369,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
networkResourceGroupName:
description: |-
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1359,6 +1359,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
networkResourceGroupName:
description: |-
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1354,6 +1354,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
networkResourceGroupName:
description: |-
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1365,6 +1365,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
networkResourceGroupName:
description: |-
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1355,6 +1355,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
networkResourceGroupName:
description: |-
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1369,6 +1369,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
networkResourceGroupName:
description: |-
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1809,6 +1809,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
networkResourceGroupName:
description: |-
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1915,6 +1915,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
ipFamily:
default: IPv4
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1900,6 +1900,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
ipFamily:
default: IPv4
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1809,6 +1809,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
networkResourceGroupName:
description: |-
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1915,6 +1915,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
ipFamily:
default: IPv4
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1915,6 +1915,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
ipFamily:
default: IPv4
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1889,6 +1889,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
ipFamily:
default: IPv4
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1671,6 +1671,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
networkResourceGroupName:
description: |-
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1755,6 +1755,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
networkResourceGroupName:
description: |-
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1675,6 +1675,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
networkResourceGroupName:
description: |-
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1655,6 +1655,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
networkResourceGroupName:
description: |-
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1651,6 +1651,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
ipFamily:
default: IPv4
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1663,6 +1663,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
networkResourceGroupName:
description: |-
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1657,6 +1657,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
networkResourceGroupName:
description: |-
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1714,6 +1714,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
networkResourceGroupName:
description: |-
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1666,6 +1666,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
networkResourceGroupName:
description: |-
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1657,6 +1657,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
networkResourceGroupName:
description: |-
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1651,6 +1651,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
networkResourceGroupName:
description: |-
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1664,6 +1664,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
networkResourceGroupName:
description: |-
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1652,6 +1652,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
networkResourceGroupName:
description: |-
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1668,6 +1668,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
networkResourceGroupName:
description: |-
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1517,6 +1517,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
networkResourceGroupName:
description: |-
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1608,6 +1608,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
ipFamily:
default: IPv4
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1593,6 +1593,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
ipFamily:
default: IPv4
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1517,6 +1517,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
networkResourceGroupName:
description: |-
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1608,6 +1608,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
ipFamily:
default: IPv4
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1608,6 +1608,7 @@ spec:
- AzureChinaCloud
- AzureGermanCloud
- AzureStackCloud
- AzureUSSecCloud
type: string
ipFamily:
default: IPv4
Expand Down
Loading