STOR-2959: Promote VolumeGroupSnapshots to GA

[jsafrane]

Promote the gate to GA.

Code was merged a long time ago, the last cleanup was merged today.

• E2e tests that run in all regular e2e parallel should have enough coverage.
• Some e2e tests are serial and thus may miss coverage, sometimes by one.

WARNING

All CI results before Jul 30 use v1beta2 API. The last PR to switched to V1 is this.
I don't think it's possible to list jobs that uses v1 group snapshot API easily.

On the positive side, v1 and v1beta2 are equal, only the version string is different.

Status on Thu Aug 06

• CI runs with v1 group snapshot api for ~1 week without issues.
• verify-feature-promotion fails because:
  • hypershift-serial job has only 3 runs instead of 14. Most of the tests on hypershift are parallel and they have enough coverage. Having zero was OK in a previous run a few days ago.
  • [sig-storage] OCP CSI Volumes [Driver: csi-hostpath-groupsnapshot] [OCPFeatureGate:VolumeGroupSnapshot] [Testpattern: Pre-provisioned PV (block volmode)] volumes should store data has failed once. The test is skipped (Skip() in the test code), but the test failed at the namespace initialization:

    panic: failed to get kubernetes.default service: Get "https://api.ci-op-rrfs8h3y-d309a.XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX:6443/api/v1/namespaces/default/services/kubernetes": dial tcp: lookup api.ci-op-rrfs8h3y-d309a.XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX on 172.30.0.10:53: read udp 10.131.40.36:40882->172.30.0.10:53: i/o timeout.

(Before you ask why do we have a test that's always skipped: it's how storage tests are generated. We generate tests with a complex test matrix, and the variant with pre-provisioned PV + CSI + block volume is not feasible because of the CSI driver we use for testing. Other volume plugins support it.)

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

Hello @jsafrane! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[coderabbitai]

📝 Walkthrough

Walkthrough

VolumeGroupSnapshot is now enabled for Default and OKD configurations in the feature-gate definition. Its feature matrix position was updated, and four Hypershift and SelfManagedHA payload manifests now list it under enabled rather than disabled feature gates.

Suggested reviewers: vr4manta, sadasu, mdbooth

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	No Ginkgo test titles were changed; the PR only touches docs, feature-gate code, and YAML manifests.
Test Structure And Quality	✅ Passed	No Ginkgo/test code changed in this PR; only feature-gate docs/manifests were updated.
Microshift Test Compatibility	✅ Passed	Only docs/config feature-gate files changed; no Ginkgo e2e test files or MicroShift-sensitive test code were added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR only updates feature-gate docs/manifests; no new Ginkgo e2e tests or SNO-unsafe assumptions were added.
Topology-Aware Scheduling Compatibility	✅ Passed	Changes only adjust feature-gate metadata and enable VolumeGroupSnapshot; no pod specs, replicas, affinity, node selectors, or topology constraints were modified.
Ote Binary Stdout Contract	✅ Passed	PR only changes feature-gate metadata/enablement; no main/init/TestMain/suite setup stdout writes were added in touched files.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR only edits feature-gate docs/config manifests; no new Ginkgo e2e tests or IP/network logic were added, so this check is not applicable.
No-Weak-Crypto	✅ Passed	Touched files only move VolumeGroupSnapshot feature-gate entries; no weak-crypto APIs/patterns or secret comparisons were introduced.
Container-Privileges	✅ Passed	Changed files are feature-gate docs/manifests only; no privileged, hostPID/hostNetwork/hostIPC, SYS_ADMIN, root, or allowPrivilegeEscalation settings found.
No-Sensitive-Data-In-Logs	✅ Passed	No logging changes; the diff only updates feature-gate enablement/docs/manifests and adds no log statements or sensitive values.
Title check	✅ Passed	The title clearly states the main change: promoting the VolumeGroupSnapshots feature gate to GA.
Description check	✅ Passed	The description explains the GA promotion, validation status, test coverage, and known CI results related to the changes.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[jsafrane]

/test verify-feature-promotion

[qodo-for-rh-openshift]

PR-Agent: could not find a component named verify-feature-promotion in a supported language in this PR.

[jsafrane]

/retest

[jsafrane]

/test verify-feature-promotion

[qodo-for-rh-openshift]

PR-Agent: could not find a component named verify-feature-promotion in a supported language in this PR.

[qodo-for-rh-openshift]

PR Summary by Qodo

Promote VolumeGroupSnapshot feature gate to GA defaults

✨ Enhancement ⚙️ Configuration changes 📝 Documentation 🕐 20-40 Minutes

AI Description

• Enable the VolumeGroupSnapshot feature gate by default (and in OKD).
• Update 4.10 payload FeatureGate manifests to include VolumeGroupSnapshot as enabled.
• Refresh the feature matrix documentation to reflect GA availability.

Diagram

graph TD
  code["features/features.go"] --> gate(("VolumeGroupSnapshot")) --> man[/"4.10 FeatureGate YAMLs"/] --> cfg[("Cluster FeatureGate config")] --> op(["CSI snapshot operator"])
  gate --> doc["features.md"]

  subgraph Legend
    direction LR
    _code["Code"] ~~~ _gate(("FeatureGate")) ~~~ _man[/"Manifest"/] ~~~ _cfg[("Cluster config")] ~~~ _svc(["Operator"])
  end

Loading

High-Level Assessment

The approach is the correct minimal change for GA promotion: enable the feature gate in the default/OKD sets and ensure payload manifests and documentation stay consistent. The only meaningful alternative (keeping it TechPreview/DevPreview-only or gating by additional cluster/profile conditions) would contradict the stated GA goal.

Files changed (6) +14 / -14

Enhancement (1) +1 / -1

features.goEnable VolumeGroupSnapshot in Default and OKD feature sets +1/-1

Enable VolumeGroupSnapshot in Default and OKD feature sets

• Updates the VolumeGroupSnapshot feature gate registration to be enabled in the Default and OKD sets in addition to the existing TechPreview/DevPreview no-upgrade sets, effectively promoting it to GA-style defaults.

features/features.go

Documentation (1) +1 / -1

features.mdMove VolumeGroupSnapshot to the GA/Enabled feature matrix section +1/-1

Move VolumeGroupSnapshot to the GA/Enabled feature matrix section

• Removes the VolumeGroupSnapshot row from its prior location and re-adds it in the main enabled matrix, aligning documentation with GA/default enablement expectations.

features.md

Other (4) +12 / -12

featureGate-4-10-Hypershift-Default.yamlAdd VolumeGroupSnapshot to 4.10 Hypershift Default enabled gates +3/-3

Add VolumeGroupSnapshot to 4.10 Hypershift Default enabled gates

• Moves VolumeGroupSnapshot into the enabled feature gate list for the Hypershift Default 4.10 payload manifest, matching the GA promotion intent.

payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml

featureGate-4-10-Hypershift-OKD.yamlAdd VolumeGroupSnapshot to 4.10 Hypershift OKD enabled gates +3/-3

Add VolumeGroupSnapshot to 4.10 Hypershift OKD enabled gates

• Ensures the Hypershift OKD 4.10 payload manifest includes VolumeGroupSnapshot as enabled, keeping OKD parity with Default behavior.

payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml

featureGate-4-10-SelfManagedHA-Default.yamlAdd VolumeGroupSnapshot to 4.10 SelfManagedHA Default enabled gates +3/-3

Add VolumeGroupSnapshot to 4.10 SelfManagedHA Default enabled gates

• Updates the SelfManagedHA Default 4.10 payload manifest to include VolumeGroupSnapshot in the enabled feature gate list.

payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml

featureGate-4-10-SelfManagedHA-OKD.yamlAdd VolumeGroupSnapshot to 4.10 SelfManagedHA OKD enabled gates +3/-3

Add VolumeGroupSnapshot to 4.10 SelfManagedHA OKD enabled gates

• Updates the SelfManagedHA OKD 4.10 payload manifest to include VolumeGroupSnapshot in the enabled feature gate list, maintaining OKD parity.

payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml

[qodo-for-rh-openshift]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

_{To customize comments, go to the Qodo configuration screen, or learn more in the docs.}

[everettraven]

/lgtm

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change
/test minor-e2e-upgrade-minor

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [everettraven]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@jsafrane: This pull request references STOR-2959 which is a valid jira issue.

Details

In response to this:

Promote the gate to GA.

Code was merged a long time ago, the last cleanup was merged today.

• E2e tests that run in all regular e2e parallel should have enough coverage.
• Some e2e tests are serial and thus may miss coverage, sometimes by one.

WARNING

All CI results before Jul 30 use v1beta2 API. The last PR to switched to V1 is this.
I don't think it's possible to list jobs that uses v1 group snapshot API easily.

On the positive side, v1 and v1beta2 are equal, only the version string is different.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jsafrane]

/retest

[jsafrane]

/test verify-feature-promotion

[qodo-for-rh-openshift]

PR-Agent: could not find a component named verify-feature-promotion in a supported language in this PR.

[jsafrane]

/retest-required
/test verify-feature-promotion

[openshift-ci]

@jsafrane: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify-hypershift-integration	0953058	link	true	/test verify-hypershift-integration
ci/prow/verify-feature-promotion	0953058	link	true	/test verify-feature-promotion

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.