Skip to content

pkg/aws/actuator: fix dropped errors#990

Open
alrs wants to merge 1 commit intoopenshift:masterfrom
alrs:actuator-errs
Open

pkg/aws/actuator: fix dropped errors#990
alrs wants to merge 1 commit intoopenshift:masterfrom
alrs:actuator-errs

Conversation

@alrs
Copy link
Copy Markdown

@alrs alrs commented Mar 20, 2026

This picks up two dropped err variables in pkg/aws/actuator. Unit tests continue to pass.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9dff8ecf-97d9-4b22-ac87-e736f9681a70

📥 Commits

Reviewing files that changed from the base of the PR and between f5fb038 and e5e877e.

📒 Files selected for processing (1)
  • pkg/aws/actuator/actuator.go

Walkthrough

The pull request adds error handling to two functions in the AWS actuator module: syncMint now validates the result of awsPolicyEqualsDesiredPolicy(), and createUser checks for errors from awsClient.GetUser().

Changes

Cohort / File(s) Summary
Error handling in AWS actuator
pkg/aws/actuator/actuator.go
Added error checking in syncMint to handle non-nil errors from awsPolicyEqualsDesiredPolicy() and in createUser to validate GetUser() results before proceeding.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can suggest fixes for GitHub Check annotations.

Configure the reviews.tools.github-checks setting to adjust the time to wait for GitHub Checks to complete.

@openshift-ci openshift-ci bot requested review from dlom and suhanime March 20, 2026 00:37
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 20, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alrs
Once this PR has been reviewed and has the lgtm label, please assign suhanime for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 20, 2026

Hi @alrs. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant