NO-JIRA: fix(e2e): handle rate limiter context deadline error during cleanup by mgencur · Pull Request #8137 · openshift/hypershift

mgencur · 2026-03-31T13:20:02Z

What this PR does / why we need it:

Treat "would exceed context deadline" from the client-side rate limiter as transient in the namespace deletion poll loop so it can be caught by wait.Interrupted and trigger finalizer removal retry.

The issue was seen in the run 2038905211862388736 on openshift/release#76214

Which issue(s) this PR fixes:

Related to https://redhat.atlassian.net/browse/CNTRLPLANE-2035

Special notes for your reviewer:

Checklist:

Subject and description added to both, commit and PR.
Relevant issues have been referenced.
This change includes docs.
This change includes unit tests.

Note

^{Cursor Bugbot is generating a summary for commit 7f0a1fe. Configure here.}

Summary by CodeRabbit

Bug Fixes
- Improved error messaging for cleanup operations when initial deletion polling times out, providing clearer feedback on timeout scenarios.
- Enhanced handling of transient client-side failures during namespace deletion, allowing the system to properly time out and recover instead of immediately failing.

Treat "would exceed context deadline" from the client-side rate limiter as transient in the namespace deletion poll loop so it can be caught by wait.Interrupted and trigger finalizer removal retry. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

openshift-ci-robot · 2026-03-31T13:20:06Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

openshift-ci-robot · 2026-03-31T13:20:07Z

@mgencur: This pull request explicitly references no jira issue.

Details

In response to this:

What this PR does / why we need it:

Treat "would exceed context deadline" from the client-side rate limiter as transient in the namespace deletion poll loop so it can be caught by wait.Interrupted and trigger finalizer removal retry.

The issue was seen in https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_release/76214/rehearse-76214-periodic-ci-openshift-hypershift-release-4.22-periodics-mce-e2e-agent-connected-ovn-ipv4-metal-backuprestore/2038905211862388736 on openshift/release#76214

Which issue(s) this PR fixes:

Related to https://redhat.atlassian.net/browse/CNTRLPLANE-2035

Special notes for your reviewer:

Checklist:

Subject and description added to both, commit and PR.

Relevant issues have been referenced.

This change includes docs.

This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-03-31T13:20:20Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 9e4d64b5-40fc-476e-8ca3-e5a706a2e026

📥 Commits

Reviewing files that changed from the base of the PR and between 4c390fb and 7f0a1fe.

📒 Files selected for processing (1)

test/e2e/v2/backuprestore/cleanup.go

📝 Walkthrough

Walkthrough

This pull request modifies error handling and messaging in test cleanup utilities for hosted cluster operations. It updates the BreakHostedClusterPreservingMachines function to provide more explicit error messages when initial deletion polling times out, and adjusts the deleteNamespace function to treat context deadline errors as transient failures that allow the polling loop to naturally expire rather than immediately returning an unexpected error.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

mgencur · 2026-03-31T13:20:41Z

/verified by @mgencur

openshift-ci-robot · 2026-03-31T13:20:54Z

@mgencur: This PR has been marked as verified by @mgencur.

Details

In response to this:

/verified by @mgencur

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-03-31T13:21:57Z

@mgencur: This pull request explicitly references no jira issue.

Details

In response to this:

What this PR does / why we need it:

Treat "would exceed context deadline" from the client-side rate limiter as transient in the namespace deletion poll loop so it can be caught by wait.Interrupted and trigger finalizer removal retry.

The issue was seen in the run 2038905211862388736 on openshift/release#76214

Which issue(s) this PR fixes:

Related to https://redhat.atlassian.net/browse/CNTRLPLANE-2035

Special notes for your reviewer:

Checklist:

Subject and description added to both, commit and PR.

Relevant issues have been referenced.

This change includes docs.

This change includes unit tests.

[!NOTE]
^{Cursor Bugbot is generating a summary for commit 7f0a1fe. Configure here.}

Summary by CodeRabbit

Bug Fixes

Improved error messaging for cleanup operations when initial deletion polling times out, providing clearer feedback on timeout scenarios.

Enhanced handling of transient client-side failures during namespace deletion, allowing the system to properly time out and recover instead of immediately failing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

codecov · 2026-03-31T13:36:11Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 26.85%. Comparing base (7e9b7be) to head (7f0a1fe).
⚠️ Report is 70 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8137      +/-   ##
==========================================
- Coverage   26.86%   26.85%   -0.01%     
==========================================
  Files        1090     1090              
  Lines      105285   105291       +6     
==========================================
- Hits        28281    28280       -1     
- Misses      74573    74580       +7     
  Partials     2431     2431

see 3 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mgencur · 2026-04-02T04:35:20Z

/retest

openshift-ci-robot · 2026-04-07T06:54:37Z

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aks-4-21
/test e2e-aws-4-21
/test e2e-aks
/test e2e-aws
/test e2e-aws-upgrade-hypershift-operator
/test e2e-azure-self-managed
/test e2e-kubevirt-aws-ovn-reduced
/test e2e-v2-aws

sdminonne · 2026-04-07T06:55:39Z

/lgtm

jparrill

/approve

openshift-ci · 2026-04-07T06:56:54Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jparrill, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [jparrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

cwbotbot · 2026-04-07T08:40:03Z

Test Results

e2e-aws

Status: ✅ PASS
Started: 2026-04-07T06:55:11Z
View Job
View Job History

e2e-aks

Status: ✅ PASS
Started: 2026-04-07T06:55:11Z
View Job
View Job History

openshift-merge-bot · 2026-04-07T08:47:35Z

/retest-required

Remaining retests: 0 against base HEAD 2d72889 and 2 for PR HEAD 7f0a1fe in total

openshift-ci · 2026-04-07T10:07:46Z

@mgencur: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 31, 2026

openshift-ci bot added the do-not-merge/needs-area label Mar 31, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 31, 2026

openshift-ci bot requested review from bryan-cox and jparrill March 31, 2026 13:21

openshift-ci bot added area/testing Indicates the PR includes changes for e2e testing and removed do-not-merge/needs-area labels Mar 31, 2026

mgencur mentioned this pull request Apr 2, 2026

Backup/restore tests for Agent and Kubevirt platform openshift/release#76214

Open

openshift-ci bot assigned sdminonne Apr 7, 2026

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2026

jparrill reviewed Apr 7, 2026

View reviewed changes

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2026

openshift-merge-bot bot merged commit 17cdd12 into openshift:main Apr 7, 2026
30 checks passed

Conversation

mgencur commented Mar 31, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist:

Summary by CodeRabbit

Uh oh!

openshift-ci-robot commented Mar 31, 2026

Uh oh!

openshift-ci-robot commented Mar 31, 2026

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist:

Uh oh!

coderabbitai bot commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Uh oh!

mgencur commented Mar 31, 2026

Uh oh!

openshift-ci-robot commented Mar 31, 2026

Uh oh!

openshift-ci-robot commented Mar 31, 2026

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist:

Summary by CodeRabbit

Uh oh!

codecov bot commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mgencur commented Apr 2, 2026

Uh oh!

openshift-ci-robot commented Apr 7, 2026

Uh oh!

sdminonne commented Apr 7, 2026

Uh oh!

jparrill left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Apr 7, 2026

Uh oh!

cwbotbot commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

e2e-aws

e2e-aks

Uh oh!

openshift-merge-bot bot commented Apr 7, 2026

Uh oh!

openshift-ci bot commented Apr 7, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mgencur commented Mar 31, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Mar 31, 2026 •

edited

Loading

codecov bot commented Mar 31, 2026 •

edited

Loading

cwbotbot commented Apr 7, 2026 •

edited

Loading