CNF-26431: Allow ironic-networking JSON-RPC port in NetworkPolicy

[alegacy]

Add port 6190 to the allow-ingress-metal NetworkPolicy to permit ingress traffic to the ironic-networking service's JSON-RPC endpoint. Without this, the default-deny policy blocks the ironic container from reaching the networking service when switch management is enabled.

Summary by CodeRabbit

• New Features
  • Enabled TCP access on port 6190 for the Ironic networking service through the metal network policy.

[coderabbitai]

Walkthrough

The metal NetworkPolicy now permits TCP ingress on port 6190 for the ironic networking JSON-RPC service.

Changes

Metal NetworkPolicy ingress

Layer / File(s)	Summary
Add ironic JSON-RPC ingress rule install/0000_90_machine-api-operator_05_networkpolicy-allow-ingress-metal.yaml	The policy allows TCP ingress on port 6190.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: theobarberbany, radekmanak

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The commit changes only a YAML NetworkPolicy by adding port 6190; it adds no test declarations or dynamic test titles.
Test Structure And Quality	✅ Passed	The commit changes only the NetworkPolicy YAML; it adds TCP port 6190 and contains no Ginkgo test code to assess.
Microshift Test Compatibility	✅ Passed	The pull request changes only a NetworkPolicy YAML file and adds no Ginkgo e2e tests, so MicroShift test compatibility checks do not apply.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The change modifies only a NetworkPolicy YAML file; the parent-to-HEAD diff adds no Ginkgo e2e tests or multi-node assumptions.
Topology-Aware Scheduling Compatibility	✅ Passed	The commit only adds TCP port 6190 to a NetworkPolicy ingress list; it adds no replicas, affinity, topology spread, selectors, tolerations, or other scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The PR changes only a NetworkPolicy YAML file by adding TCP port 6190; it changes no OTE binary, suite setup, or process-level stdout/logging code.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The patch changes only a NetworkPolicy YAML file and adds no Ginkgo e2e tests or external connectivity code.
No-Weak-Crypto	✅ Passed	The parent-to-HEAD diff only adds TCP port 6190 to a NetworkPolicy; it introduces no weak crypto, custom crypto, or secret/token comparison.
Container-Privileges	✅ Passed	The commit only adds TCP port 6190 to a NetworkPolicy; it adds no privileged, host namespace, SYS_ADMIN, root, or allowPrivilegeEscalation setting.
No-Sensitive-Data-In-Logs	✅ Passed	The commit changes only a NetworkPolicy by adding TCP port 6190; it adds no logging code or sensitive data.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the NetworkPolicy change and the ironic-networking JSON-RPC port it allows.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign racheljpg for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@install/0000_90_machine-api-operator_05_networkpolicy-allow-ingress-metal.yaml`:
- Around line 32-33: Update the network policy rule for TCP port 6190 to include
a `from` restriction and limit ingress to the required source workloads, while
narrowing the selected target pods if necessary so only the intended workloads
receive this access; do not leave the rule broadly applicable to every pod.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d4234e0a-46a6-4934-a2bd-7928aa6c0618

📥 Commits

Reviewing files that changed from the base of the PR and between 0db39ee and 6f6e47a.

📒 Files selected for processing (1)

• install/0000_90_machine-api-operator_05_networkpolicy-allow-ingress-metal.yaml

[coderabbitai]

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

[openshift-ci-robot]

@alegacy: This pull request references CNF-26431 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Add port 6190 to the allow-ingress-metal NetworkPolicy to permit ingress traffic to the ironic-networking service's JSON-RPC endpoint. Without this, the default-deny policy blocks the ironic container from reaching the networking service when switch management is enabled.

Summary by CodeRabbit

• New Features
• Enabled TCP access on port 6190 for the Ironic networking service through the metal network policy.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@alegacy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6	68ba6d2	link	true	/test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-metal-ipi-virtualmedia	68ba6d2	link	true	/test e2e-metal-ipi-virtualmedia

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.