OCPBUGS-73946: Ignore (Dev|Tech)PreviewNoUpgrade FeatureSets #6082

copejon · 2026-01-14T20:19:57Z

If microshift config contains apiServer.featureGates.featureSet: DevPreviewNoUpgrade, microshift will refuse to start.

After the prohibited featureset is removed from the config, microshift will once again start.

openshift-ci-robot · 2026-01-14T20:20:04Z

@copejon: This pull request references Jira Issue OCPBUGS-71208, which is invalid:

expected the bug to target either version "4.22." or "openshift-4.22.", but it targets "4.21" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

If microshift config contains apiServer.featureGates.featureSet: DevPreviewNoUpgrade, microshift will refuse to start.

After the prohibited featureset is removed from the config, microshift will once again start.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-01-14T20:20:23Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: copejon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [copejon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

copejon · 2026-01-14T21:58:03Z

Unrelated RF test failure from TLS drop-in config suite.

/retest-required

agullon · 2026-01-15T11:00:29Z

@copejon I think we should treat TechPreviewNoUpgrade same way as DevPreviewNoUpgrade because any FeatureGate in TechPreviewNoUpgrade and DevPreviewNoUpgrade Feature sets can break MicroShift.

So I suggest expanding the change in this ticket and PR to also TechPreviewNoUpgrade.

copejon · 2026-01-16T00:05:05Z

Pausing until we have a decision on MicroShift supporting specific tech-preview features

/hold

openshift-ci-robot · 2026-01-16T19:30:04Z

@copejon: This pull request references Jira Issue OCPBUGS-73946, which is invalid:

expected the bug to target only the "4.22.0" version, but multiple target versions were set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

If microshift config contains apiServer.featureGates.featureSet: DevPreviewNoUpgrade, microshift will refuse to start.

After the prohibited featureset is removed from the config, microshift will once again start.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

copejon · 2026-01-16T19:30:05Z

/jira refresh

openshift-ci-robot · 2026-01-16T19:30:09Z

@copejon: This pull request references Jira Issue OCPBUGS-73946, which is invalid:

expected the bug to target only the "4.22.0" version, but multiple target versions were set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-01-19T22:59:05Z

@copejon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

copejon · 2026-01-20T01:18:35Z

/unhold

agullon · 2026-01-20T10:14:17Z

pkg/config/apiserver.go

-	// Must set CustomNoUpgrade enabled or disabled lists when FeatureSet is CustomNoUpgrade
-	if fg.FeatureSet == FeatureSetCustomNoUpgrade && len(fg.CustomNoUpgrade.Enabled) == 0 && len(fg.CustomNoUpgrade.Disabled) == 0 {
-		return fmt.Errorf("CustomNoUpgrade enabled or disabled lists must be set when FeatureSet is CustomNoUpgrade")
-	}


why do you remove this check? afaiu this is still relevant

Looking at OpenShift kubebuilder validation, empty lists are accepted for CustomNoUpgrade. This makes sense because OpenShift also doesn't restrict changes to the enable/disable FG lists.

understood, thanks

agullon · 2026-01-20T10:16:08Z

pkg/config/apiserver.go

+		}
+		return nil
+	case FeatureSetCustomNoUpgrade:
+		// Valid - continue to validate enabled/disabled lists below


what lists below do you refer to?

"lists" just refers to additional validations further down (L195-L217)

understood, thanks

agullon · 2026-01-20T10:20:25Z

pkg/config/config_test.go

+				return c
+			}(),
+			expectErr: true,
+		},


Suggested change

},

},

{

name: "feature-gates-custom-no-upgrade-with-empty-enabled-and-disabled-lists",

config: func() *Config {

c := mkDefaultConfig()

c.ApiServer.FeatureGates.FeatureSet = "CustomNoUpgrade"

c.ApiServer.FeatureGates.CustomNoUpgrade.Enabled = []string{}

c.ApiServer.FeatureGates.CustomNoUpgrade.Disabled = []string{}

return c

}(),

expectErr: true,

},

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 14, 2026

openshift-ci bot requested review from agullon and vanhalenar January 14, 2026 20:20

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2026

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2026

copejon changed the title ~~OCPBUGS-71208: Prohibit DevPreviewNoUpgrade feature due to incompatible feature gate~~ OCPBUGS-73946: Ignore (Dev|Tech)PreviewNoUpgrade FeatureSets Jan 16, 2026

openshift-ci-robot added the jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. label Jan 16, 2026

pacevedom and others added 2 commits January 19, 2026 15:27

USHIFT-6487: Set aws machine name limit to 64

1910b01

do not allow users to set Dev/TechPreview feature sets

81654ae

copejon force-pushed the OCPBUGS-71208 branch from ca9efca to 81654ae Compare January 19, 2026 21:28

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2026

agullon reviewed Jan 20, 2026

View reviewed changes

-		},
+		},
+		{
+			name: "feature-gates-custom-no-upgrade-with-empty-enabled-and-disabled-lists",
+			config: func() *Config {
+				c := mkDefaultConfig()
+				c.ApiServer.FeatureGates.FeatureSet = "CustomNoUpgrade"
+				c.ApiServer.FeatureGates.CustomNoUpgrade.Enabled = []string{}
+				c.ApiServer.FeatureGates.CustomNoUpgrade.Disabled = []string{}
+				return c
+			}(),
+			expectErr: true,
+		},

OCPBUGS-73946: Ignore (Dev|Tech)PreviewNoUpgrade FeatureSets #6082

Are you sure you want to change the base?

OCPBUGS-73946: Ignore (Dev|Tech)PreviewNoUpgrade FeatureSets #6082

Conversation

copejon commented Jan 14, 2026

Uh oh!

openshift-ci-robot commented Jan 14, 2026

Uh oh!

openshift-ci bot commented Jan 14, 2026

Uh oh!

copejon commented Jan 14, 2026

Uh oh!

agullon commented Jan 15, 2026

Uh oh!

copejon commented Jan 16, 2026

Uh oh!

openshift-ci-robot commented Jan 16, 2026

Uh oh!

copejon commented Jan 16, 2026

Uh oh!

openshift-ci-robot commented Jan 16, 2026

Uh oh!

openshift-ci bot commented Jan 19, 2026

Uh oh!

copejon commented Jan 20, 2026

Uh oh!

agullon Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

copejon Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

agullon Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

agullon Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

copejon Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

agullon Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

agullon Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants