[OSDOCS-17908]: Configuring ingress end point for a hosted cluster#107009
[OSDOCS-17908]: Configuring ingress end point for a hosted cluster#107009lahinson merged 2 commits intoopenshift:mainfrom
Conversation
openshift-ci
bot
added
the
size/M
openshift-ci
bot
added
size/L
lahinson
force-pushed
the
osdocs-17908-hcp-ingress-controller
branch
from
08bb347 to
41e41ef
Compare
openshift-ci
bot
added
size/M
lahinson
force-pushed
the
osdocs-17908-hcp-ingress-controller
branch
3 times, most recently
from
b6b13d1 to
1d49244
Compare
openshift-ci
bot
added
size/L
lahinson
added
the
do-not-merge/hold
lahinson
force-pushed
the
osdocs-17908-hcp-ingress-controller
branch
from
1d49244 to
281d557
Compare
lahinson
force-pushed
the
osdocs-17908-hcp-ingress-controller
branch
from
281d557 to
c24291f
Compare
|
@mburke5678 Thanks for your review! I'm going to have QE give this one more check to ensure that my latest updates are accurate. I'll remove this from the merge review queue for the moment. |
lahinson
removed
merge-review-in-progress
|
A few comments. Otherwise LGTM |
lahinson
force-pushed
the
osdocs-17908-hcp-ingress-controller
branch
from
c24291f to
6312529
Compare
|
New changes are detected. LGTM label has been removed. |
|
Per QE review from the IBM Z team, I'm removing the ingress endpoint step from the IBM Z module, as it is not yet supported on that platform. |
lahinson
force-pushed
the
osdocs-17908-hcp-ingress-controller
branch
from
6312529 to
f66033a
Compare
|
@lahinson: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherrypick enterprise-4.21 |
|
/cherrypick enterprise-4.22 |
|
@lahinson: new pull request created: #107710 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@lahinson: new pull request created: #107711 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| ---- | ||
| #... | ||
| spec: | ||
| operatorConfiguration: |
There was a problem hiding this comment.
Sorry for being late. This PR looks good. The only thing is the formatting of this snippet. Can you move the lines after "spec" to left? The indentation between spec and the following lines should be only two spaces.
8 participants
Version(s): 4.21+
Issue: https://issues.redhat.com/browse/OSDOCS-17908
Link to docs preview:
QE review:
Additional information: This PR adds instructions about how to configure the endpoint for a nodeport at cluster creation time so that load balancer configuration is easier. I also made a few updates to the files to ensure that they are compliant with the upcoming migration to DITA.