OSDOCS-17086: Fix DITA compatibility errors in MicroShift low latency docs (CQA)#107027
OSDOCS-17086: Fix DITA compatibility errors in MicroShift low latency docs (CQA)#107027DCChadwick wants to merge 1 commit intoopenshift:mainfrom
Conversation
|
@DCChadwick: This pull request references OSDOCS-17086 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
1 similar comment
|
@DCChadwick: This pull request references OSDOCS-17086 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
ab4a54e to
2cd4e06
Compare
|
@DCChadwick There is already a procedure in the docs, see https://docs.redhat.com/en/documentation/red_hat_build_of_microshift/4.21/html/configuring/configuring-low-latency#microshift-low-latency-config-yaml_microshift-low-latency. I am not sure why we have a new procedure added here? |
2cd4e06 to
84ba053
Compare
|
@ShaunaDiaz - Thanks! Great catch. There's definitely overlap , but from what I understand (and I could totally have this wrong) LLC locality is a highly specific Tech preview feature that targets AMD CPUs. I'm thinking that if we drop this PR entirely, users on Intel CPUs might just copy/paste the currently documented procedure as is and maybe break their clusters or miss the TP warnings. I could rewrite this module to clearly state it's an add-on configuration instead of presenting it as a standalone file replacement. But the Jira ticket is a little vague, so I could've just misunderstood what was needed. So first, I'll check in with Kathryn and Ashley to see what they're thinking. |
|
@DCChadwick: This pull request references OSDOCS-17086 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
84ba053 to
0a6e8e1
Compare
0a6e8e1 to
5beb2fa
Compare
@DCChadwick This is not what a CQA is. This feature was added already and does not need to be rewritten. Also, do not remove related Additional resources from between modules. These are to stay in place for conversion. I urge you again to review the scope of CQA work. I also urge you to get a clear understanding of what MicroShift is (it does not have clusters). |
5ed7856 to
1d5b27b
Compare
microshift_configuring/microshift_low_latency/microshift-low-latency.adoc
Outdated
Show resolved
Hide resolved
microshift_configuring/microshift_low_latency/microshift-low-latency.adoc
Outdated
Show resolved
Hide resolved
microshift_configuring/microshift_low_latency/microshift-low-latency.adoc
Outdated
Show resolved
Hide resolved
microshift_configuring/microshift_low_latency/microshift-low-latency.adoc
Outdated
Show resolved
Hide resolved
be0d2d8 to
f8bfe81
Compare
|
@ShaunaDiaz Thanks for the feedback. I have removed the out-of-scope llc-config module and restored the original placement of the Additional resources sections to meet the CQA structural requirements. |
f8bfe81 to
893e021
Compare
|
@DCChadwick: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Version(s):
Issue: OSDOCS-17086
Link to docs preview:
QE review:
Additional information: