OSDOCS-17045-5: CQA for MACH-4 Cluster API for Compute Machines#114350
Conversation
|
@dfitzmau: This pull request references OSDOCS-17045 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
Bot
added
the
size/M
dfitzmau
changed the title
dfitzmau
added
the
merge-review-needed
|
/label merge-review-in-progress |
openshift-ci
Bot
added
the
merge-review-in-progress
brendan-daly-red-hat
left a comment
brendan-daly-red-hat
left a comment
There was a problem hiding this comment.
Looks good, Darragh. I added one optional suggestion. As I'm a new merge reviewer, @bscott-rh will confirm this review.
| = Cluster API resources migration to Machine API resources | ||
|
|
||
| [role="_abstract"] | ||
| On clusters that support migrating between Machine API and Cluster API resources, the two-way synchronization controller supports converting a Cluster API resource to a Machine API resource. |
There was a problem hiding this comment.
| On clusters that support migrating between Machine API and Cluster API resources, the two-way synchronization controller supports converting a Cluster API resource to a Machine API resource. | |
| On clusters that support migrating between the Cluster API and Machine API resources, the two-way synchronization controller supports converting a Cluster API resource to a Machine API resource. |
Optional suggestion for consistency with the heading and the next line.
bscott-rh
left a comment
bscott-rh
left a comment
There was a problem hiding this comment.
Merge review confirmed
bscott-rh
added
ok-to-merge
and removed
merge-review-in-progress
|
@dfitzmau: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherrypick enterprise-4.22 |
|
/cherrypick enterprise-4.21 |
|
/cherrypick enterprise-4.20 |
|
/cherrypick enterprise-5.0 |
|
@dfitzmau: new pull request created: #114476 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@dfitzmau: new pull request created: #114477 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@dfitzmau: new pull request created: #114478 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@dfitzmau: new pull request created: #114479 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
6 participants
Version(s):
4.20+
Issue:
OSDOCS-17045
Link to docs preview:
Continue from machine_management/cluster_api_machine_management/cluster_api_provider_configurations/cluster-api-config-options-vsphere.adoc'