Skip to content

Move Excluding resources section to Migration controller options#114432

Open
arpitbhagat wants to merge 1 commit into
openshift:enterprise-4.20from
arpitbhagat:fix-excluding-resources-section-4.20
Open

Move Excluding resources section to Migration controller options#114432
arpitbhagat wants to merge 1 commit into
openshift:enterprise-4.20from
arpitbhagat:fix-excluding-resources-section-4.20

Conversation

@arpitbhagat

@arpitbhagat arpitbhagat commented Jun 30, 2026

Copy link
Copy Markdown

Summary

  • Move the "Excluding resources" module (migration-excluding-resources.adoc) from the "Migration plan options" section to the "Migration controller options" section in both MTC assembly files
  • Update the "Migration controller options" intro text to mention resource exclusion

Problem

The "Excluding resources" section is currently placed under "Migration plan options", which opens with:

"You can exclude, edit, and map components in the MigPlan custom resource (CR)."

However, this section exclusively documents MigrationController CR parameters (additional_excluded_resources, disable_image_migration, disable_pv_migration). The YAML example shows kind: MigrationController, and the procedure instructs users to oc edit migrationcontroller.

This placement misleads users into believing these are MigPlan fields. When users run oc explain migplan.spec, the fields are not found because they belong to the MigrationController CR.

Fix

Moved the include::modules/migration-excluding-resources.adoc from the "Migration plan options" section to the "Migration controller options" section in both assembly files:

  • migration_toolkit_for_containers/advanced-migration-options-mtc.adoc
  • migrating_from_ocp_3_to_4/advanced-migration-options-3-4.adoc

Updated the "Migration controller options" intro text to include "exclude resources" alongside the other capabilities.

Before (section structure)

Migration plan options (MigPlan CR) Migration controller options (MigrationController CR)
Excluding resources (wrong - documents MigrationController CR) Increasing limits
Mapping namespaces PV resizing
Excluding PVCs Cached clients

After (section structure)

Migration plan options (MigPlan CR) Migration controller options (MigrationController CR)
Mapping namespaces Excluding resources (moved here)
Excluding PVCs Increasing limits
... PV resizing
Cached clients

Verification

  • Cross-references to #migration-excluding-resources_{context} remain valid since the module is still included in the same assembly files
  • Confirmed on MTC 1.8.15 / OCP 4.20: oc explain migplan.spec does not contain additional_excluded_resources — it is a MigrationController CR field
  • The module content (migration-excluding-resources.adoc) is unchanged — only its placement in the assembly files is corrected

Test plan

  • Verify rendered docs show "Excluding resources" under "Migration controller options" instead of "Migration plan options"
  • Verify cross-reference from premigration-checklists-3-4.adoc still resolves correctly
  • Verify no broken links in either assembly

…ration controller options

The "Excluding resources" section (migration-excluding-resources.adoc) documents
MigrationController CR parameters (additional_excluded_resources,
disable_image_migration, disable_pv_migration) but was incorrectly placed under
"Migration plan options" which describes MigPlan CR fields.

This move corrects the section placement so that:
- "Migration plan options" only contains MigPlan CR operations
- "Migration controller options" contains all MigrationController CR operations
  including resource exclusion

Also updates the "Migration controller options" intro text to mention resource
exclusion.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci openshift-ci Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 30, 2026
@openshift-ci

openshift-ci Bot commented Jun 30, 2026

Copy link
Copy Markdown

Hi @arpitbhagat. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant