Move Excluding resources section to Migration controller options#114432
Open
arpitbhagat wants to merge 1 commit into
Open
Move Excluding resources section to Migration controller options#114432arpitbhagat wants to merge 1 commit into
arpitbhagat wants to merge 1 commit into
Conversation
…ration controller options The "Excluding resources" section (migration-excluding-resources.adoc) documents MigrationController CR parameters (additional_excluded_resources, disable_image_migration, disable_pv_migration) but was incorrectly placed under "Migration plan options" which describes MigPlan CR fields. This move corrects the section placement so that: - "Migration plan options" only contains MigPlan CR operations - "Migration controller options" contains all MigrationController CR operations including resource exclusion Also updates the "Migration controller options" intro text to mention resource exclusion. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Hi @arpitbhagat. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
migration-excluding-resources.adoc) from the "Migration plan options" section to the "Migration controller options" section in both MTC assembly filesProblem
The "Excluding resources" section is currently placed under "Migration plan options", which opens with:
However, this section exclusively documents MigrationController CR parameters (
additional_excluded_resources,disable_image_migration,disable_pv_migration). The YAML example showskind: MigrationController, and the procedure instructs users tooc edit migrationcontroller.This placement misleads users into believing these are MigPlan fields. When users run
oc explain migplan.spec, the fields are not found because they belong to the MigrationController CR.Fix
Moved the
include::modules/migration-excluding-resources.adocfrom the "Migration plan options" section to the "Migration controller options" section in both assembly files:migration_toolkit_for_containers/advanced-migration-options-mtc.adocmigrating_from_ocp_3_to_4/advanced-migration-options-3-4.adocUpdated the "Migration controller options" intro text to include "exclude resources" alongside the other capabilities.
Before (section structure)
After (section structure)
Verification
#migration-excluding-resources_{context}remain valid since the module is still included in the same assembly filesoc explain migplan.specdoes not containadditional_excluded_resources— it is a MigrationController CR fieldmigration-excluding-resources.adoc) is unchanged — only its placement in the assembly files is correctedTest plan
premigration-checklists-3-4.adocstill resolves correctly