OCPBUGS-84512: Remove exception terminationMessagePolicy=TerminationMessageFallbackToLogsOnError by theobarberbany · Pull Request #31327 · openshift/origin

theobarberbany · 2026-06-23T11:13:07Z

Removes the exception for cloud-provider-aws on terminationMessagePolicy=FallbackToLogsOnError violations

Summary by CodeRabbit

Bug Fixes
- Removed a previously exempt namespace entry, so TerminationMessagePolicy issues that may have been ignored before are now reported consistently. Previously exempt pods/containers in that namespace may now show as new violations, subject to the existing version and message-matching behavior.

openshift-merge-bot · 2026-06-23T11:13:09Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

openshift-ci-robot · 2026-06-23T11:13:09Z

@theobarberbany: No Jira issue with key CPBUGS-84512 exists in the tracker at https://redhat.atlassian.net.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

Details

In response to this:

Removes the exception for cloud-provider-aws on terminationMessagePolicy=FallbackToLogsOnError violations

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-06-23T11:13:23Z

@theobarberbany: This pull request references Jira Issue OCPBUGS-84512, which is invalid:

expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Removes the exception for cloud-provider-aws on terminationMessagePolicy=FallbackToLogsOnError violations

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

theobarberbany · 2026-06-23T11:13:24Z

/jira refresh

openshift-ci-robot · 2026-06-23T11:13:29Z

@theobarberbany: This pull request references Jira Issue OCPBUGS-84512, which is invalid:

expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-06-23T11:13:32Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 3a6fe9eb-2ffe-40f6-ac3f-1520170fd32a

📥 Commits

Reviewing files that changed from the base of the PR and between e9bc246 and 9dd1119.

📒 Files selected for processing (1)

pkg/monitortests/clusterversionoperator/terminationmessagepolicy/monitortest.go

🚧 Files skipped from review as they are similar to previous changes (1)

pkg/monitortests/clusterversionoperator/terminationmessagepolicy/monitortest.go

Walkthrough

The termination message policy monitor test removes the openshift-cloud-controller-manager grandfathered exemption and keeps the ephemeralContainers policy check logic unchanged apart from formatting.

Changes

Termination message policy monitor test

Layer / File(s)	Summary
Exemption removal and loop formatting `pkg/monitortests/clusterversionoperator/terminationmessagepolicy/monitortest.go`	Removes the `openshift-cloud-controller-manager` entry from `existingViolations` and reformats the `ephemeralContainers` loop around the `TerminationMessagePolicy` check without changing its behavior.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: removing an exception for terminationMessagePolicy violations.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR only removes a namespace exception and reflows code; no Ginkgo It/Describe/Context/When titles were added or changed.
Test Structure And Quality	✅ Passed	The PR only changes a monitor analyzer file; it contains no Ginkgo specs, Eventually/Consistently calls, or assertion blocks, so the checklist is not applicable.
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e tests were added; the only changed file is monitor-test logic with no It/Describe/Context/When blocks or MicroShift-specific concerns.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS: The PR only edits a monitor/junit analyzer; no new Ginkgo tests or SNO-sensitive node assumptions were added, so the check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	Only a monitor test changed; no scheduling constraints, topology checks, or workload placement logic were added.
Ote Binary Stdout Contract	✅ Passed	The PR only removes an exception and reformats code; the touched file has no process-level stdout writes or suite/setup entrypoints.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Only monitor-test helper logic changed; no new Ginkgo e2e tests or IPv4/external connectivity assumptions were added.
No-Weak-Crypto	✅ Passed	Diff only reflows comments and removes a namespace exception in a terminationMessagePolicy test; no weak crypto, custom crypto, or secret comparisons added.
Container-Privileges	✅ Passed	Only a Go monitor test file changed; no K8s/container manifests or privilege settings (privileged, hostPID/network/IPC, SYS_ADMIN, allowPrivilegeEscalation) were added.
No-Sensitive-Data-In-Logs	✅ Passed	Changed code only adjusts a test whitelist and formats junit failure strings; it adds no logging or sensitive-data emission.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

theobarberbany · 2026-06-23T11:13:56Z

/jira refresh

openshift-ci-robot · 2026-06-23T11:14:03Z

@theobarberbany: This pull request references Jira Issue OCPBUGS-84512, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (5.0.0) matches configured target version for branch (5.0.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

miyadav · 2026-06-23T11:20:43Z

/approve

openshift-merge-bot · 2026-06-23T11:48:38Z

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

theobarberbany · 2026-06-23T12:33:42Z

/pipeline auto

openshift-merge-bot · 2026-06-23T12:33:50Z

The /pipeline auto command is only available for LGTM-mode repositories. For repositories in automatic mode, second-stage tests are already triggered automatically.

miyadav · 2026-06-23T12:34:46Z

/lgtm

miyadav · 2026-06-23T15:50:17Z

/test e2e-gcp-ovn

theobarberbany · 2026-06-24T12:03:51Z

@miyadav The GCP failures are unrelated to this change, can we override?

miyadav · 2026-06-24T12:47:47Z

/override e2e-gcp-ovn

openshift-ci · 2026-06-24T12:50:02Z

@miyadav: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

e2e-gcp-ovn

Only the following failed contexts/checkruns were expected:

CodeRabbit
ci/prow/e2e-aws-csi
ci/prow/e2e-aws-ovn-fips
ci/prow/e2e-aws-ovn-microshift
ci/prow/e2e-aws-ovn-microshift-serial
ci/prow/e2e-aws-ovn-serial-1of2
ci/prow/e2e-aws-ovn-serial-2of2
ci/prow/e2e-gcp-csi
ci/prow/e2e-gcp-ovn
ci/prow/e2e-gcp-ovn-upgrade
ci/prow/e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-vsphere-ovn
ci/prow/e2e-vsphere-ovn-upi
ci/prow/go-verify-deps
ci/prow/images
ci/prow/lint
ci/prow/okd-scos-images
ci/prow/unit
ci/prow/verify
ci/prow/verify-deps
pull-ci-openshift-origin-main-e2e-aws-csi
pull-ci-openshift-origin-main-e2e-aws-ovn-fips
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift-serial
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-2of2
pull-ci-openshift-origin-main-e2e-gcp-csi
pull-ci-openshift-origin-main-e2e-gcp-ovn
pull-ci-openshift-origin-main-e2e-gcp-ovn-upgrade
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-ipv6
pull-ci-openshift-origin-main-e2e-vsphere-ovn
pull-ci-openshift-origin-main-e2e-vsphere-ovn-upi
pull-ci-openshift-origin-main-go-verify-deps
pull-ci-openshift-origin-main-images
pull-ci-openshift-origin-main-lint
pull-ci-openshift-origin-main-okd-scos-images
pull-ci-openshift-origin-main-unit
pull-ci-openshift-origin-main-verify
pull-ci-openshift-origin-main-verify-deps
tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override e2e-gcp-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

miyadav · 2026-06-24T12:50:07Z

/override ci/prow/e2e-gcp-ovn

openshift-ci · 2026-06-24T12:52:19Z

@miyadav: Overrode contexts on behalf of miyadav: ci/prow/e2e-gcp-ovn

Details

In response to this:

/override ci/prow/e2e-gcp-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

…essageFallbackToLogsOnError Removes the exception for cloud-provider-aws on terminationMessagePolicy=FallbackToLogsOnError violations

miyadav · 2026-07-08T16:04:42Z

/lgtm

openshift-ci · 2026-07-08T16:07:03Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: miyadav, theobarberbany

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [miyadav]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-merge-bot · 2026-07-08T16:26:59Z

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

theobarberbany · 2026-07-08T16:48:44Z

/verified by ci - this is just rebase changes

openshift-ci-robot · 2026-07-08T16:48:56Z

@theobarberbany: This PR has been marked as verified by ci - this is just rebase changes.

Details

In response to this:

/verified by ci - this is just rebase changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

theobarberbany · 2026-07-08T21:11:03Z

/retest required

theobarberbany · 2026-07-08T21:11:38Z

/retest

openshift-merge-bot · 2026-07-09T02:18:49Z

/retest-required

Remaining retests: 0 against base HEAD 965e8a0 and 2 for PR HEAD 9dd1119 in total

theobarberbany · 2026-07-09T09:20:20Z

/retest

openshift-ci · 2026-07-09T14:09:39Z

@theobarberbany: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2026-07-09T14:12:43Z

@theobarberbany: Jira Issue OCPBUGS-84512: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-84512 has been moved to the MODIFIED state.

Details

In response to this:

Removes the exception for cloud-provider-aws on terminationMessagePolicy=FallbackToLogsOnError violations

Fixed by openshift/release#80840

Summary by CodeRabbit

Summary by CodeRabbit

Bug Fixes

Removed a previously exempt namespace entry, so TerminationMessagePolicy issues that may have been ignored before are now reported consistently. Previously exempt pods/containers in that namespace may now show as new violations, subject to the existing version and message-matching behavior.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-robot · 2026-07-10T02:49:25Z

Fix included in release 5.0.0-0.nightly-2026-07-09-200130

theobarberbany changed the title ~~CPBUGS-84512: Remove exception terminationMessagePolicy=TerminationMessageFallbackToLogsOnError~~ OCPBUGS-84512: Remove exception terminationMessagePolicy=TerminationMessageFallbackToLogsOnError Jun 23, 2026

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 23, 2026

openshift-ci Bot requested review from deads2k and sjenning June 23, 2026 11:14

coderabbitai Bot approved these changes Jun 23, 2026

View reviewed changes

openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Jun 23, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2026

openshift-ci Bot assigned miyadav Jun 23, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2026

theobarberbany force-pushed the tb/remove-cloud-provider-aws-exception branch from e9bc246 to 6697cf0 Compare July 8, 2026 15:58

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2026

OCPBUGS-84512: Remove exception terminationMessagePolicy=TerminationM…

9dd1119

…essageFallbackToLogsOnError Removes the exception for cloud-provider-aws on terminationMessagePolicy=FallbackToLogsOnError violations

theobarberbany force-pushed the tb/remove-cloud-provider-aws-exception branch from 6697cf0 to 9dd1119 Compare July 8, 2026 15:59

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jul 8, 2026

openshift-merge-bot Bot merged commit a40276a into openshift:main Jul 9, 2026
21 checks passed

Uh oh!

Conversation

theobarberbany commented Jun 23, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Summary by CodeRabbit

Uh oh!

openshift-merge-bot Bot commented Jun 23, 2026

Uh oh!

openshift-ci-robot commented Jun 23, 2026

Uh oh!

openshift-ci-robot commented Jun 23, 2026

Uh oh!

theobarberbany commented Jun 23, 2026

Uh oh!

openshift-ci-robot commented Jun 23, 2026

Uh oh!

coderabbitai Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

theobarberbany commented Jun 23, 2026

Uh oh!

openshift-ci-robot commented Jun 23, 2026

Uh oh!

miyadav commented Jun 23, 2026

Uh oh!

openshift-merge-bot Bot commented Jun 23, 2026

Uh oh!

theobarberbany commented Jun 23, 2026

Uh oh!

openshift-merge-bot Bot commented Jun 23, 2026

Uh oh!

miyadav commented Jun 23, 2026

Uh oh!

miyadav commented Jun 23, 2026

Uh oh!

theobarberbany commented Jun 24, 2026

Uh oh!

miyadav commented Jun 24, 2026

Uh oh!

openshift-ci Bot commented Jun 24, 2026

Uh oh!

miyadav commented Jun 24, 2026

Uh oh!

openshift-ci Bot commented Jun 24, 2026

Uh oh!

miyadav commented Jul 8, 2026

Uh oh!

openshift-ci Bot commented Jul 8, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 8, 2026

Uh oh!

theobarberbany commented Jul 8, 2026

Uh oh!

openshift-ci-robot commented Jul 8, 2026

Uh oh!

theobarberbany commented Jul 8, 2026

Uh oh!

theobarberbany commented Jul 8, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 9, 2026

Uh oh!

theobarberbany commented Jul 9, 2026

Uh oh!

openshift-ci Bot commented Jul 9, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Jul 9, 2026

Summary by CodeRabbit

Summary by CodeRabbit

Uh oh!

openshift-merge-robot commented Jul 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

theobarberbany commented Jun 23, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 23, 2026 •

edited

Loading