OCPBUGS-84513: remove openshift-cluster-version terminationMessagePolicy exemption

[jrangelramos]

Summary

• Remove the openshift-cluster-version exemption from the existingViolations map in the terminationMessagePolicy monitor test

Context

The CVO fix in openshift/cluster-version-operator#1417 adds terminationMessagePolicy=FallbackToLogsOnError to all containers in the dynamically-created update-payload pods. With that fix in place, the exemption here is no longer needed and should be removed so violations are enforced as hard failures.

Dependencies

This PR must not merge until openshift/cluster-version-operator#1417 has merged and landed in a payload. Merging this first would turn the currently-flaking test into a hard failure.

Test plan

• Confirm OCPBUGS-84513: set terminationMessagePolicy on update-payload pods cluster-version-operator#1417 has merged and is in the payload
• Verify [Monitor:termination-message-policy][sig-arch] all containers in ns/openshift-cluster-version passes without flaking

Fixes https://redhat.atlassian.net/browse/OCPBUGS-84513

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes
  • Updated test handling for containers in the openshift-cluster-version namespace by removing a legacy “grandfathered” violation exception.
  • These containers are now evaluated using the standard logic (rather than being exempt), improving the accuracy of the resulting fail/flake behavior in older-version scenarios.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci-robot]

@jrangelramos: This pull request references Jira Issue OCPBUGS-84513, which is invalid:

• expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

• Remove the openshift-cluster-version exemption from the existingViolations map in the terminationMessagePolicy monitor test

Context

The CVO fix in openshift/cluster-version-operator#1417 adds terminationMessagePolicy=FallbackToLogsOnError to all containers in the dynamically-created update-payload pods. With that fix in place, the exemption here is no longer needed and should be removed so violations are enforced as hard failures.

Dependencies

This PR must not merge until openshift/cluster-version-operator#1417 has merged and landed in a payload. Merging this first would turn the currently-flaking test into a hard failure.

Test plan

• Confirm OCPBUGS-84513: set terminationMessagePolicy on update-payload pods cluster-version-operator#1417 has merged and is in the payload
• Verify [Monitor:termination-message-policy][sig-arch] all containers in ns/openshift-cluster-version passes without flaking

Fixes https://redhat.atlassian.net/browse/OCPBUGS-84513

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: dd3be469-353d-4c73-ad1a-4217d1424c72

📥 Commits

Reviewing files that changed from the base of the PR and between 737ed83 and bd94cbc.

📒 Files selected for processing (1)

• pkg/monitortests/clusterversionoperator/terminationmessagepolicy/monitortest.go

💤 Files with no reviewable changes (1)

• pkg/monitortests/clusterversionoperator/terminationmessagepolicy/monitortest.go

---

Walkthrough

A single removal deletes the openshift-cluster-version grandfathered exception from the termination message policy monitor test, so containers in that namespace follow the remaining violation classification logic.

Changes

Termination Message Policy Exception Removal

Layer / File(s)	Summary
Remove grandfathered exception entry pkg/monitortests/clusterversionoperator/terminationmessagepolicy/monitortest.go	Removes the existingViolations["openshift-cluster-version"] entry from the exception map, changing namespace classification during test generation.

Estimated code review effort: 1 (Trivial) | ~3 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the core change: removing the openshift-cluster-version terminationMessagePolicy exemption.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	No Ginkgo titles with dynamic values were added; the package’s only test names are static t.Run cases, and fmt.Sprintf is used only for JUnit output, not test titles.
Test Structure And Quality	✅ Passed	PR only removes one exemption from a monitor analyzer; no Ginkgo It blocks, waits, or resource setup/cleanup were added.
Microshift Test Compatibility	✅ Passed	The touched file is a monitor analyzer, not a Ginkgo e2e test, and contains no It/Describe/Context/When blocks or MicroShift-specific APIs.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The PR only removes one grandfathered violation in a monitor test package; no new Ginkgo e2e tests or SNO-sensitive node/topology assumptions were added.
Topology-Aware Scheduling Compatibility	✅ Passed	Only a test exemption was removed; no deployment, controller, or scheduling logic changed, so no topology-aware scheduling risk was introduced.
Ote Binary Stdout Contract	✅ Passed	The PR only removes a map exemption; it adds no process-level stdout writes, and the file’s init() uses fmt.Sprintf only.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Changed file is a monitor analyzer only; it adds no Ginkgo e2e test code and no IPv4 or external connectivity assumptions.
No-Weak-Crypto	✅ Passed	PR only removes a test exemption; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons are present.
Container-Privileges	✅ Passed	Diff only removes an exemption entry in a Go monitor test; no privileged/hostPID/hostNetwork/hostIPC/SYS_ADMIN/runAsUser=0/allowPrivilegeEscalation changes were added.
No-Sensitive-Data-In-Logs	✅ Passed	Only an exemption entry was removed; no new logging or sensitive-data output was added.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jrangelramos
Once this PR has been reviewed and has the lgtm label, please assign jogeo for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[jrangelramos]

/retest-required

[jrangelramos]

/retest-required

[jrangelramos]

/retest-required

[openshift-ci-robot]

@jrangelramos: This pull request references Jira Issue OCPBUGS-84513, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

Summary

• Remove the openshift-cluster-version exemption from the existingViolations map in the terminationMessagePolicy monitor test

Context

The CVO fix in openshift/cluster-version-operator#1417 adds terminationMessagePolicy=FallbackToLogsOnError to all containers in the dynamically-created update-payload pods. With that fix in place, the exemption here is no longer needed and should be removed so violations are enforced as hard failures.

Dependencies

This PR must not merge until openshift/cluster-version-operator#1417 has merged and landed in a payload. Merging this first would turn the currently-flaking test into a hard failure.

Test plan

• Confirm OCPBUGS-84513: set terminationMessagePolicy on update-payload pods cluster-version-operator#1417 has merged and is in the payload
• Verify [Monitor:termination-message-policy][sig-arch] all containers in ns/openshift-cluster-version passes without flaking

Fixes https://redhat.atlassian.net/browse/OCPBUGS-84513

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes
• Updated test handling for containers in the openshift-cluster-version namespace by removing a legacy “grandfathered” violation exception.
• These containers are now evaluated using the standard logic (rather than being exempt), improving the accuracy of the resulting fail/flake behavior in older-version scenarios.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[openshift-ci]

@jrangelramos: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6	bd94cbc	link	true	/test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-vsphere-ovn-upi	bd94cbc	link	true	/test e2e-vsphere-ovn-upi
ci/prow/e2e-gcp-ovn	bd94cbc	link	true	/test e2e-gcp-ovn
ci/prow/e2e-vsphere-ovn	bd94cbc	link	true	/test e2e-vsphere-ovn
ci/prow/e2e-aws-ovn-fips	bd94cbc	link	true	/test e2e-aws-ovn-fips

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.