Add native OLM e2e test for SBR CI using optional-operators workflow

[ugreener]

Adds a new openshift-e2e-olm presubmit test that validates Storage Based Remediation (SBR) operator installation through the standard customer deployment path (CatalogSource + Subscription via the optional-operators-ci-aws workflow), targeting the openshift-workload-availability namespace.

Changes:

• Added sbd-operator-bundle bundle entry (without skip_building_index) to enable CI index image generation
• Added openshift-e2e-olm test with four steps: namespace PSA configuration, CI agent image injection into the CSV, ODF storage setup, and e2e test execution
• Uses active polling for OLM CSV propagation instead of static sleep
• Generated corresponding Prow presubmit jobs via make update
• The existing openshift-e2e test remains completely unchanged

[openshift-ci]

Hi @ugreener. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ugreener]

/cc @mshitrit

[mshitrit]

/pj-rehearse

[openshift-ci-robot]

@mshitrit: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

[openshift-ci-robot]

@mshitrit: needs-ok-to-test label found, no rehearsals will be run

[razo7]

Can we avoid making changes to a running (and working) e2e test workflow?
Given that this PR and motivation are experimental (we don't know if it will work or meet our new needs/goals), I prefer not to break what is working for now. We can achieve that in two ways:

• Create an e2e test for main on OCP 4.21/4.22
• Add a new test (after as: openshift-e2e) with all your new changes under OCP 4.20

Don't forget to run make update to create a job and run a rehearsal of the test you affected

[mshitrit]

prefer not to break what is working for now. We can achieve that in two ways:

• Create an e2e test for main on OCP 4.21/4.22
• Add a new test (after as: openshift-e2e) with all your new changes under OCP 4.20

That SGTM.

Currently the first option is blocked by https://redhat.atlassian.net/browse/RHWA-761 , so in case you decide to go with that option, let me know so I can push it's fix priority.

[ugreener]

@razo7 The PR has been restructured to leave the existing openshift-e2e test completely unchanged from main. A new openshift-e2e-olm test has been added alongside it under OCP 4.20. make update was run to regenerate the Prow jobs, resulting in a purely additive diff.

Please re-review and comment /ok-to-test.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ugreener
Once this PR has been reviewed and has the lgtm label, please ask for approval from razo7. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/config/medik8s/storage-based-remediation/OWNERS
• ci-operator/jobs/medik8s/storage-based-remediation/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

[REHEARSALNOTIFIER]
@ugreener: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-medik8s-storage-based-remediation-main-4.20-ci-index-sbd-operator-bundle	medik8s/storage-based-remediation	presubmit	Presubmit changed
pull-ci-medik8s-storage-based-remediation-main-4.20-openshift-e2e-olm	medik8s/storage-based-remediation	presubmit	Presubmit changed
pull-ci-medik8s-storage-based-remediation-main-4.20-ci-bundle-my-bundle	medik8s/storage-based-remediation	presubmit	Ci-operator config changed
pull-ci-medik8s-storage-based-remediation-main-4.20-images	medik8s/storage-based-remediation	presubmit	Ci-operator config changed
pull-ci-medik8s-storage-based-remediation-main-4.20-openshift-e2e	medik8s/storage-based-remediation	presubmit	Ci-operator config changed

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[slintes]

Can we avoid making changes to a running (and working) e2e test workflow?
Given that this PR and motivation are experimental (we don't know if it will work or meet our new needs/goals), I prefer not to break what is working for now.

Why this? What is experimental here? Why don't we know if it works? We will know by running rehearsals, not? 🤔