Update the mqeditor to use MathQuill's new internal toolbar.#1417
Open
drgrice1 wants to merge 1 commit into
Open
Update the mqeditor to use MathQuill's new internal toolbar.#1417drgrice1 wants to merge 1 commit into
drgrice1 wants to merge 1 commit into
Conversation
Contributor
|
I'm unsure that I am testing this correctly. I cloned the mathquill repo at Then I checked out this branch of pg and in |
These are changes needed to use the new internal toolbar implemented in openwebwork/mathquill#46. To test this you need to use that branch. Clone that branch somewhere on the webwork2 server, and then in the directory of that clone execute ```bash npm ci npm run build npm link ``` Then in the `pg/htdocs` directory run `npm link @openwebwork/mathquill`. After doing so if you look at `pg/htdocs/node_modules/@openwebwork/mathquill` you will see that it is now a link to the MathQuill clone above. Execute `npm ci` again to reset that back to the currently published MathQuill version. Once openwebwork/mathquill#46 is merged, I will publish it and add it to this pull request. So don't merge this pull request until then.
drgrice1
force-pushed
the
mathquill-internal-toolbar
branch
from
9cafe67 to
45bdd18
Compare
Member
Author
|
I changed the testing instructions a bit. There were some steps I missed that might be why you weren't seeing the changes in effect. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are changes needed to use the new internal toolbar implemented in openwebwork/mathquill#46. To test this you need to use that branch. Clone that branch somewhere on the webwork2 server, and then in the directory of that clone execute
Then checkout the branch for this pull request in the
/opt/webwork/pgdirectory (or wherever you have the PG repository). Make sure you runnpm ciin thepg/htdocsdirectory before doing the following so that the JavaScript and css for PG is all updated.Then in the
pg/htdocsdirectory runnpm link @openwebwork/mathquill. After doing so if you look atpg/htdocs/node_modules/@openwebwork/mathquillyou will see that it is now a link to the MathQuill clone above.Now restart the webwork2 app.
One last important step. Since the
package.jsonfile is not changed (so the version of @openwebwork/mathquill is still reported as the same), the browser may still load the cached version of MathQuill. So you may need to do a hard refresh in the browser to get it to load the updated MathQuill javascript.When you are done testing this branch, execute
npm ciagain to remove the symbolic link and go back to using the currently published MathQuill version.Once openwebwork/mathquill#46 is merged, I will publish the changes in openwebwork/mathquill#46 and add it to this pull request. So don't merge this pull request until then.