Make the problem graders also save the sub_status when needed.

[drgrice1]

Basically, anytime that reduced scoring is not enabled or if it is but it is before the reduced scoring period, then the sub_status needs to also be set to the same thing as the status. Otherwise the "unreduced" score will not be computed correctly. So the problem graders now take this into account.

This fixes issue #2873.

[drgrice1]

Perhaps this should be considered for a hotfiix.

[drgrice1]

Also note that achievement item usage does not need a fix here. Achievement items already set the sub_status regardless of the reduced scoring status.

[Alex-Jordan]

I set out to test this, starting out by going to the develop branch (on both pg and sebwork2). I wanted to repeat the issue first. For both repos, I ran npm ci, and then restarted webwork2.

But now when I click to Save the score I enter, I get an error message

Error saving score.
Unknown server communication error.

This is any time I try to use the grader, not just the conditions from #2873. Are you still able to produce the original issue on develop? Does this other error arise for you?

[Alex-Jordan]

I must be having some other issue. The library browser is all messed up too, not rendering problems.

[somiaj]

Do you have a configuration issue with your development server (maybe the rpc isn't trying to talk to the right location?)

[drgrice1]

Do you have perlcritic installed? That is a new dependency due to the merge of the pg critic pull requests. I tested the develop branch on my remove production server and had the same issue, and the reason was that I did not have perlcritic installed. On Ubuntu install the libperl-critic-perl package. I don't think you use Ubuntu, so you will need to figure out the package for your distribution (Oracle I beleive?) or install from cpan. The perl module is Perl::Critic.

Note that the server will work without having the package installed, but the webwork web service will fail to compile, particularly the WebworkWebservice::ProblemActions module, since it depends on the WeBWorK::PG::Critic package which uses the Perl::Critic module.

We need to remember to add this to the installation instructions and release notes.

[drgrice1]

Note that the PPI package is also needed, but if you install Perl::Critic that should also be installed. It is a dependency of Perl::Critic.

[drgrice1]

Also note that check_modules.pl has been updated for this.