Skip to content

Remove the script tag processing of MathJax. - #3129

Open
drgrice1 wants to merge 1 commit into
openwebwork:developfrom
drgrice1:mathjax-no-script-process
Open

Remove the script tag processing of MathJax.#3129
drgrice1 wants to merge 1 commit into
openwebwork:developfrom
drgrice1:mathjax-no-script-process

Conversation

@drgrice1

@drgrice1 drgrice1 commented Aug 12, 2026

Copy link
Copy Markdown
Member

The injection of <script type="math/tex">...</script> tags by PG is removed by openwebwork/pg#1499. So the script tag handling in the mathjax-config.js file is no longer needed.

@somiaj

somiaj commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

I think you linked the wrong PR in the commit and description.

@drgrice1
drgrice1 force-pushed the mathjax-no-script-process branch from f353e5c to e3d32a9 Compare August 13, 2026 15:09
@drgrice1

Copy link
Copy Markdown
Member Author

Should this be a hotfix also? It is actually not necessary for openwebwork/pg#1501.

@somiaj

somiaj commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

I could go either way. I doubt not processing script tags that aren't there won't speed things up in a noticeable fashion. But couldn't hurt.

@Alex-Jordan

Copy link
Copy Markdown
Contributor

I won't have time to check this (and the associated PR in pg) until later today. But the one thing on my mind to check is how/if PTX inserts any math (specifically for defining an author's LaTeX macros) into the iframe srcdoc for an embedded webwork file. If there's a real issue there, it's possible that it would be better to leave this be on main and give me a year to work out something different for 2.22 and beyond.

The injection of `<script type="math/tex">...</script>` tags by PG is
removed by openwebwork/pg#1499.  So the script
tag handling in the `mathjax-config.js` file is no longer needed.
@drgrice1
drgrice1 force-pushed the mathjax-no-script-process branch from e3d32a9 to 0c5695c Compare August 13, 2026 19:59
@somiaj

somiaj commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

@Alex-Jordan well this doesn't need to be a hotfix, and is independent of the PG one, in the sense we could remove using of script tags from PG (PGML isn't using them already), but leave this alone so webwork can still process them if something like pretext needs that processing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants