Fix update on fresh workpackages, add parent and description mutation flags#17
Open
EatonChips wants to merge 2 commits into
Open
Fix update on fresh workpackages, add parent and description mutation flags#17EatonChips wants to merge 2 commits into
EatonChips wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
N/A
What are you trying to accomplish?
Add support for setting work package descriptions and parent relations through the CLI.
Updating a freshly created workpackage with a
lockVersionof 0 always fails.op create workpackage --descriptionop create workpackage --description-fileop create workpackage --parentop update workpackage --descriptionop update workpackage --description-fileop update workpackage --parentWhat approach did you choose and why?
Flags were added using Cobra, and the DTOs were updated to include the fields the API already supports. This was just plumbing to route the cli argument into the final struct shape.
The
lockVersionshould always be sent, even if 0. It is required by the PATCH handler, newly created workpackages initialize with a 0 value.