Corrected protocol typing for IPHost.value IPAddress -> IPInterface#892
Corrected protocol typing for IPHost.value IPAddress -> IPInterface#892
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThe type annotations for the 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying infrahub-sdk-python with
|
| Latest commit: |
c4302f5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fc260e0f.infrahub-sdk-python.pages.dev |
| Branch Preview URL: | https://pog-iphost-typing-ihs-215.infrahub-sdk-python.pages.dev |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## stable #892 +/- ##
=======================================
Coverage 80.68% 80.68%
=======================================
Files 119 119
Lines 10335 10335
Branches 1550 1550
=======================================
Hits 8339 8339
Misses 1473 1473
Partials 523 523
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Why
The typing for IPHost.value within the protocol class was incorrect
What changed
Fixes #891
Summary by CodeRabbit