Skip to content

[AI-FSSDK] [FSSDK-12418] Remove experiment type validation from config parsing #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FarhanAnjum-opti wants to merge 1 commit into
base: master
Choose a base branch
from
+13 −18
Open

[AI-FSSDK] [FSSDK-12418] Remove experiment type validation from config parsing #402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions OptimizelySDK.Tests/ProjectConfigTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1736,6 +1736,19 @@ public void TestTypeFieldParsedCorrectly()
Assert.AreEqual("fr", rolloutExperiment.Type);
}

[Test]
public void TestUnknownExperimentTypeAccepted()
{
var datafile = BuildFeatureRolloutDatafile(experimentType: "new_unknown_type");
var config = DatafileProjectConfig.Create(datafile, LoggerMock.Object,
ErrorHandlerMock.Object);

Assert.IsNotNull(config);
var experiment = config.GetExperimentFromKey("rollout_experiment");
Assert.IsNotNull(experiment);
Assert.AreEqual("new_unknown_type", experiment.Type);
}

#endregion
}
}
18 changes: 0 additions & 18 deletions OptimizelySDK/Config/DatafileProjectConfig.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,26 +375,8 @@ private void Initialize()
}
}

var validExperimentTypes = new HashSet<string>
{
Experiment.EXPERIMENT_TYPE_AB,
Experiment.EXPERIMENT_TYPE_MAB,
Experiment.EXPERIMENT_TYPE_CMAB,
Experiment.EXPERIMENT_TYPE_TD,
Experiment.EXPERIMENT_TYPE_FR,
};

foreach (var experiment in _ExperimentIdMap.Values)
{
if (experiment.Type != null && !validExperimentTypes.Contains(experiment.Type))
{
Logger.Log(LogLevel.ERROR,
$@"Experiment ""{experiment.Key}"" has invalid type ""{experiment.Type}"".");
ErrorHandler.HandleError(
new InvalidExperimentException(
$"Invalid experiment type: {experiment.Type}"));
}

_VariationKeyMap[experiment.Key] = new Dictionary<string, Variation>();
_VariationIdMap[experiment.Key] = new Dictionary<string, Variation>();
_VariationIdMapByExperimentId[experiment.Id] = new Dictionary<string, Variation>();
Expand Down
Loading