Skip to content

[AI-FSSDK] [FSSDK-12418] Remove experiment type validation from config parsing#500

Merged
esrakartalOpt merged 1 commit intomasterfrom
ai/farhananjum-opti/FSSDK-12418-remove-type-validation
Apr 8, 2026
Merged

[AI-FSSDK] [FSSDK-12418] Remove experiment type validation from config parsing#500
esrakartalOpt merged 1 commit intomasterfrom
ai/farhananjum-opti/FSSDK-12418-remove-type-validation

Conversation

@FarhanAnjum-opti
Copy link
Copy Markdown
Contributor

@FarhanAnjum-opti FarhanAnjum-opti commented Apr 2, 2026

Summary

Removes experiment type validation from config parsing to ensure forward compatibility. Previously, unknown experiment type values caused errors and could reject the entire datafile, which would break existing SDK versions when new experiment types are added in the future.

Changes

  • Removed type validation block that rejected experiments with unknown type values
  • Changed Experiment entity type field from strict Literal type to flexible string type
  • Added test verifying unknown experiment types are silently accepted during config parsing

Jira Ticket

FSSDK-12418

Copy link
Copy Markdown
Contributor

@esrakartalOpt esrakartalOpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@esrakartalOpt esrakartalOpt merged commit 54ae4c6 into master Apr 8, 2026
16 checks passed
@esrakartalOpt esrakartalOpt deleted the ai/farhananjum-opti/FSSDK-12418-remove-type-validation branch April 8, 2026 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants