Skip to content

ci: update workflows (checkout v6, recursive submodules), prep for mbedTLS v4, Windows fixes#3529

Merged
airween merged 16 commits intoowasp-modsecurity:v3/masterfrom
Easton97-Jens:v3/master_update_workflows
Apr 1, 2026
Merged

ci: update workflows (checkout v6, recursive submodules), prep for mbedTLS v4, Windows fixes#3529
airween merged 16 commits intoowasp-modsecurity:v3/masterfrom
Easton97-Jens:v3/master_update_workflows

Conversation

@Easton97-Jens
Copy link
Copy Markdown
Contributor

@Easton97-Jens Easton97-Jens commented Mar 29, 2026

What

  • Based on the approach from PR fix(ci): pin Lua version on 5.4 #3524, but implemented with adjusted behavior to better fit the current CI structure
  • Reworked and unified CI workflows so that all jobs run consistently
  • Removed GeoIP-related steps from CI to reduce complexity
  • Updated actions/checkout from v4 to v6
  • Switched submodule handling to recursive
  • Added dynamic Lua version detection on Linux (no more manual version maintenance required)
  • Improved CI configuration as preparation for mbedTLS v4 compatibility
  • Fixed Windows workflow so tests now pass successfully

Why

  • PR fix(ci): pin Lua version on 5.4 #3524 introduces important Lua version pinning changes, which are taken into account here but implemented in a more flexible way
  • The previous CI setup was not fully aligned and harder to maintain
  • Dynamic Lua detection reduces maintenance effort and avoids hardcoded versions
  • Removing GeoIP simplifies CI and reduces potential failure points
  • Unified workflows improve maintainability and consistency
  • actions/checkout@v6 is the current recommended version
  • Recursive submodules ensure all dependencies are properly fetched
  • Changes serve as a preparation step towards mbedTLS v4 compatibility
  • Windows CI was failing previously and is now fixed

Notes

Updated CI workflow to dynamically detect and install the latest Lua development package instead of using a fixed version.
@Easton97-Jens Easton97-Jens requested a review from airween March 29, 2026 16:20
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the GitHub Actions CI workflows to align job structure/behavior across OSes, adjust dependency installation (notably Lua), and fetch submodules recursively.

Changes:

  • Added Lua package auto-detection on Linux and adjusted dependency install lists (including Python tooling).
  • Updated checkout configuration to use recursive submodules and changed the referenced actions/checkout major version.
  • Tweaked workflow matrices/strategy settings (e.g., fail-fast: false) and removed GeoIP-related CI steps.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 9 comments.

File Description
.github/workflows/ci_new.yml Updates the “new” CI workflow: Linux/macOS/Windows jobs, Lua detection, dependency installs, recursive submodules, and cppcheck jobs.
.github/workflows/ci.yml Aligns the primary CI workflow with the new structure: Lua detection, dependency updates, recursive submodules, and fail-fast behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@airween
Copy link
Copy Markdown
Member

airween commented Mar 30, 2026

@Easton97-Jens,

please consider to approve Copilot suggestions'.

I think none of them are exactly true (especially this one: brew install python3 is likely to fail; use brew install python), because all tests were passed, but I think those are useful, and you should accept them. But let's discuss, if you have any question.

Removed python3 from the installation steps in the CI workflow.
Removed python3 from the installation list in CI workflow.
@Easton97-Jens
Copy link
Copy Markdown
Contributor Author

Thanks for the suggestion! This is not strictly required, as Python 3 is already available in the environment, so no additional installation is needed. Therefore, I have removed the installation entirely.

@Easton97-Jens Easton97-Jens changed the title ci: update workflows (checkout v6, recursive submodules), mbedTLS v4 compatibility, Windows fix ci: update workflows (checkout v6, recursive submodules), prep for mbedTLS v4, Windows fixes Mar 31, 2026
@Easton97-Jens Easton97-Jens requested a review from airween April 1, 2026 12:26
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@airween
Copy link
Copy Markdown
Member

airween commented Apr 1, 2026

Thanks @Easton97-Jens, merging now.

@airween airween merged commit da00c6d into owasp-modsecurity:v3/master Apr 1, 2026
102 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants