Skip to content

feat: enhance thumbnail generation - #4946

Open
alexknop wants to merge 2 commits into
owncloud:masterfrom
alexknop:feature/enhancethumbnails
Open

feat: enhance thumbnail generation#4946
alexknop wants to merge 2 commits into
owncloud:masterfrom
alexknop:feature/enhancethumbnails

Conversation

@alexknop

Copy link
Copy Markdown

Related Issues

  • No logged issue, but I keep my photo albums in Owncloud and noticed that many thumbnails stop showing on large albums and performance is very slow. Usually a thumbnail is loading one at a time and can take 2 seconds per thumbnail

Solution:

  • Increase thumbnail cache disk from 10 MB to 250 MB
  • Migrated thumbnail loading from AsyncTask to Coil
  • Caching ImageLoader instead of creating a new one on every request

App:

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@alexknop
alexknop requested a review from a team as a code owner July 31, 2026 18:52
@jesmrec

jesmrec commented Aug 3, 2026

Copy link
Copy Markdown
Member

hi @alexknop!! thanks for your contribution. We'll check it as soon as posible.

Some inputs about, in order to put the code in shape:

  • Review the commit naming, it does not pass the conventional commits validation CI check

  • The static code analyzer CI check is also red. This is the message: ThumbnailsRequester.kt:118:1: Line detected, which is longer than the defined maximum line length in the code style. [MaxLineLength] . Please wrap the line.

  • Calens file lacks of endline and description. A quick review will be appreciated ;)

@jesmrec jesmrec changed the title Enhance thumbnail generation feat: enhance thumbnail generation Aug 3, 2026
@alexknop
alexknop force-pushed the feature/enhancethumbnails branch from 2a628ad to c50529c Compare August 3, 2026 16:40
@alexknop

alexknop commented Aug 3, 2026

Copy link
Copy Markdown
Author

@jesmrec This is done. I was a bit confused on the two AccountUtils files but believe I referenced the correct one in the ThumbnailRequester file.

@jesmrec

jesmrec commented Aug 4, 2026

Copy link
Copy Markdown
Member

Cool @alexknop!! as in #4943, i'd suggest to compact the calens file. Again, my suggestion:

Enhancement: Thumbnail caching

Thumbnail caching system has been improved for a better experience and performance.

<link>

Calens file is intended to be a quick entry, not a complete description of the work. For that aim, the issue/PR is the best option. Changelog should be read at a glance.

Thanks again for your engagement!

@alexknop
alexknop force-pushed the feature/enhancethumbnails branch from 60d5592 to 842234a Compare August 5, 2026 03:16
@alexknop

alexknop commented Aug 5, 2026

Copy link
Copy Markdown
Author

@jesmrec done, thank you for your feedback. I'll get the hang of these things eventually...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants