AI junk#3664
Closed
mayoka0 wants to merge 2 commits into
Closed
Conversation
HelpFormatter.write_usage wrapped the argument string with the default break_on_hyphens=True, so a long option pushed onto a new line could be split at one of its internal hyphens (e.g. '--max-' / 'retry-count'). Add a break_on_hyphens parameter to wrap_text and pass break_on_hyphens= False from write_usage, so the usage line only wraps between options. Other wrap_text callers are unaffected (default stays True).
davidism
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3362.
HelpFormatter.write_usagewrapped the arguments string with the defaultbreak_on_hyphens=True, so a long option that got pushed onto a new line could be split at one of its internal hyphens:This adds a
break_on_hyphensparameter towrap_textand passesbreak_on_hyphens=Falsefromwrite_usage, so the usage line only ever wraps between options (at spaces):Other
wrap_textcallers are unaffected — the default staysTrue.Added
test_write_usage_does_not_break_options_at_hyphens. Fulltests/test_formatting.pypasses (36) and a broader run oftest_formatting.py+test_basic.py(129) is green.